From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,PDS_TONAME_EQ_TOLOCAL_SHORT,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C579C433E0 for ; Sun, 24 Jan 2021 13:37:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 64B9D22D58 for ; Sun, 24 Jan 2021 13:37:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727002AbhAXNhd (ORCPT ); Sun, 24 Jan 2021 08:37:33 -0500 Received: from mail.kernel.org ([198.145.29.99]:45394 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726993AbhAXNhb (ORCPT ); Sun, 24 Jan 2021 08:37:31 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id B17F522DD6; Sun, 24 Jan 2021 13:37:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1611495422; bh=N5oMPbzb4SoRG0bkDCgFkxwkfJP8IM3lBBHC07nCeww=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sk6YGCZ3IyDjUavH3FEnJBFgUtujQ6jNzzg62AGAUAJuHxVQ570dSB5gkaREu5Zxe X5ZCFyuWiJgoLLQXEA0q7Huft2Vz7NP+qfWKIUhZjBQ/j2de1DunO/NHIL/xWKKJ5c 6+g4rTxVvIxJHfc7Fbiu6znKnFnPO2wIUvnL9Ujo= Date: Sun, 24 Jan 2021 14:36:33 +0100 From: Greg KH To: angkery Cc: linux@roeck-us.net, heikki.krogerus@linux.intel.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Junlin Yang Subject: Re: [PATCH v2] usb: typec: tcpci_maxim: remove redundant assignment Message-ID: References: <20210124133137.1468-1-angkery@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210124133137.1468-1-angkery@163.com> Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Sun, Jan 24, 2021 at 09:31:37PM +0800, angkery wrote: > From: Junlin Yang > > PTR_ERR(chip->tcpci) has been used as a return value, > it is not necessary to assign it to ret, so remove it. > And add terminating '\n' to the formats where missed too. > > Signed-off-by: Junlin Yang > --- > v2: add terminating '\n' to the formats where missed too. Don't mix different things in the same patch, this should be a patch series of 2 patches. thanks, greg k-h