From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72697C433E6 for ; Thu, 28 Jan 2021 07:44:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 11B016146D for ; Thu, 28 Jan 2021 07:44:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232152AbhA1HoW (ORCPT ); Thu, 28 Jan 2021 02:44:22 -0500 Received: from mail.kernel.org ([198.145.29.99]:35342 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232034AbhA1HmK (ORCPT ); Thu, 28 Jan 2021 02:42:10 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id D815064DD1; Thu, 28 Jan 2021 07:41:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1611819689; bh=UIZAl1ypNxIx0VC4863WBaN/fRN2pw975WDiM1ldZGk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bXuKnZrNYpxXInKGae/o3bmzevQexIN83M+3UnxY8xgDrBJRnYGrfEMs2pKdOLMke 1A/LQeDq0t99Hwa1TuLGNrAPTD355YKPfzazqeg85TyoVXyVxu++UCgN2Uco9EBDR+ STnAyFRkCoI9UMSiMGJfm6xrrYEC1pqVuooxeT8k= Date: Thu, 28 Jan 2021 08:41:25 +0100 From: Greg KH To: Mathias Nyman Cc: Howard Yen , Mathias Nyman , robh+dt@kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/4] add xhci hooks for USB offload Message-ID: References: <20210119101044.1637023-1-howardyen@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Thu, Jan 28, 2021 at 08:31:14AM +0200, Mathias Nyman wrote: > On 28.1.2021 5.38, Howard Yen wrote: > > On Tue, Jan 26, 2021 at 10:19 PM Greg KH wrote: > >> > >> On Fri, Jan 22, 2021 at 05:32:58PM +0200, Mathias Nyman wrote: > >>> > >>> Ok, before adding hooks like this I think we need to see how they are used. > >>> Do you have the rest of the patches that go on top of this series? > >>> > >>> Maybe it could make sense to use overrides for the functions in struct hc_driver > >>> instead in some cases? There is support for that already. > >> > >> What overrides could be done for these changes? At first glance that > >> would seem to require a lot of duplicated code in whatever override > >> happens to be needed. > >> > >> thanks, > >> > >> greg k-h > > > > This patch series is all the changes for the offload hooks currently. > > > > I thought about this, but if I tried to override the functions in > > struct hc_driver, that'll need to > > copy many code to the override function, and it won't follow the > > latest change in the core > > xhci driver. > > > > > > - Howard > > Ok, I see. > > The point I'm trying to make is that there is no way for me to know if > these hooks are the right solution before I see any code using them. > > Is the offloading code ready and public somewhere? There is offload code published in the last few Samsung phone kernels, I want to get that ported to these hooks to see if that works properly. Give me a few days and I'll see if I can get it working, I had a half-finished port around here somewhere... thanks, greg k-h