* [PATCH] usb: typec: remove unused variable ‘ret’ in typec_partner_set_pd_revision
@ 2021-02-04 1:24 Ye Bin
2021-02-04 6:22 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Ye Bin @ 2021-02-04 1:24 UTC (permalink / raw)
To: heikki.krogerus, gregkh, linux-usb, linux-kernel; +Cc: Ye Bin, Hulk Robot
Fix follow warning:
drivers/usb/typec/class.c:763:6: warning: unused variable ‘ret’ [-Wunused-variable]
int ret;
^~~
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Ye Bin <yebin10@huawei.com>
---
drivers/usb/typec/class.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c
index b6ceab3dc16b..1c2d50e016e2 100644
--- a/drivers/usb/typec/class.c
+++ b/drivers/usb/typec/class.c
@@ -760,8 +760,6 @@ EXPORT_SYMBOL_GPL(typec_partner_set_identity);
*/
int typec_partner_set_pd_revision(struct typec_partner *partner, u16 pd_revision)
{
- int ret;
-
if (partner->pd_revision == pd_revision)
return 0;
--
2.25.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: typec: remove unused variable ‘ret’ in typec_partner_set_pd_revision
2021-02-04 1:24 [PATCH] usb: typec: remove unused variable ‘ret’ in typec_partner_set_pd_revision Ye Bin
@ 2021-02-04 6:22 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2021-02-04 6:22 UTC (permalink / raw)
To: Ye Bin; +Cc: heikki.krogerus, linux-usb, linux-kernel, Hulk Robot
On Thu, Feb 04, 2021 at 09:24:30AM +0800, Ye Bin wrote:
> Fix follow warning:
> drivers/usb/typec/class.c:763:6: warning: unused variable ‘ret’ [-Wunused-variable]
> int ret;
> ^~~
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Ye Bin <yebin10@huawei.com>
> ---
> drivers/usb/typec/class.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c
> index b6ceab3dc16b..1c2d50e016e2 100644
> --- a/drivers/usb/typec/class.c
> +++ b/drivers/usb/typec/class.c
> @@ -760,8 +760,6 @@ EXPORT_SYMBOL_GPL(typec_partner_set_identity);
> */
> int typec_partner_set_pd_revision(struct typec_partner *partner, u16 pd_revision)
> {
> - int ret;
> -
> if (partner->pd_revision == pd_revision)
> return 0;
>
This is already fixed in my tree, right? What did you make this
against?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-04 6:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-04 1:24 [PATCH] usb: typec: remove unused variable ‘ret’ in typec_partner_set_pd_revision Ye Bin
2021-02-04 6:22 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).