Re: [PATCH v3] Goodix Fingerprint device is not a modem

[Greg KH <greg@kroah.com>]

On Fri, Feb 12, 2021 at 12:10:48PM +0100, Yorick de Wid wrote:
> The CDC ACM driver is false matching the Goodix Fingerprint device against
> the USB_CDC_ACM_PROTO_AT_V25TER.
> 
> Keep the entries sorted on in VID/PID.
> 
> Signed-off-by: Yorick de Wid <ydewid@gmail.com>
> ---
>  drivers/usb/class/cdc-acm.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
> index 78190574581..2f4e5174e78 100644
> --- a/drivers/usb/class/cdc-acm.c
> +++ b/drivers/usb/class/cdc-acm.c
> @@ -1929,6 +1929,11 @@ static const struct usb_device_id acm_ids[] = {
>  	.driver_info = SEND_ZERO_PACKET,
>  	},
>  
> +	/* Exclude Goodix Fingerprint Reader */
> +	{ USB_DEVICE(0x27c6, 0x5395),
> +	.driver_info = IGNORE_DEVICE,
> +	},
> +
>  	/* control interfaces without any protocol set */
>  	{ USB_INTERFACE_INFO(USB_CLASS_COMM, USB_CDC_SUBCLASS_ACM,
>  		USB_CDC_PROTO_NONE) },
> -- 
> 2.30.0
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/SubmittingPatches for what needs to be done
  here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot