linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH fixed 1/1] USB: serial: ch341: add new Product ID
@ 2021-02-26 18:38 Niv Sardi
  2021-03-01  9:26 ` Johan Hovold
  0 siblings, 1 reply; 2+ messages in thread
From: Niv Sardi @ 2021-02-26 18:38 UTC (permalink / raw)
  To: linux-usb; +Cc: Niv Sardi

Add PID for CH340 that's found on cheap programers. They are sometimes refered to as ANU232MI like in this one:
https://www.nordfield.com/downloads/anu232mi/ANU232MI-datasheet.pdf

The driver works flawlessly as soon as the new PID (0x9986) is added to it.

Signed-off-by: Niv Sardi <xaiki@evilgiggle.com>
---
 drivers/usb/serial/ch341.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/serial/ch341.c b/drivers/usb/serial/ch341.c
index 28deaaec581f..f26861246f65 100644
--- a/drivers/usb/serial/ch341.c
+++ b/drivers/usb/serial/ch341.c
@@ -86,6 +86,7 @@ static const struct usb_device_id id_table[] = {
 	{ USB_DEVICE(0x1a86, 0x7522) },
 	{ USB_DEVICE(0x1a86, 0x7523) },
 	{ USB_DEVICE(0x4348, 0x5523) },
+	{ USB_DEVICE(0x9986, 0x7523) },
 	{ },
 };
 MODULE_DEVICE_TABLE(usb, id_table);
-- 
2.30.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH fixed 1/1] USB: serial: ch341: add new Product ID
  2021-02-26 18:38 [PATCH fixed 1/1] USB: serial: ch341: add new Product ID Niv Sardi
@ 2021-03-01  9:26 ` Johan Hovold
  0 siblings, 0 replies; 2+ messages in thread
From: Johan Hovold @ 2021-03-01  9:26 UTC (permalink / raw)
  To: Niv Sardi; +Cc: linux-usb

On Fri, Feb 26, 2021 at 03:38:36PM -0300, Niv Sardi wrote:
> Add PID for CH340 that's found on cheap programers. They are sometimes refered to as ANU232MI like in this one:
> https://www.nordfield.com/downloads/anu232mi/ANU232MI-datasheet.pdf

That datasheet clearly states that it uses a PL2303 which is a
different chip.

Sure, the id looks like they could be for a CH341, but please clear up
this apparent confusion (i.e. explain it).

And include the output of 'lsusb -v' for reference.

> The driver works flawlessly as soon as the new PID (0x9986) is added to it.
> 
> Signed-off-by: Niv Sardi <xaiki@evilgiggle.com>
> ---

Please get into the custom of running scripts/checkpatch.pl on your
patches before submission, which would have let you know about some
spelling errors and unbroken lines.

And add a patch revision to your subject prefix (e.g. PATCH v2) when
resending and include a short changelog here so we know what changes
since previous versions.

Johan

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-03-01  9:27 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-26 18:38 [PATCH fixed 1/1] USB: serial: ch341: add new Product ID Niv Sardi
2021-03-01  9:26 ` Johan Hovold

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).