* [PATCH -next] usb: remove unused including <linux/version.h>
@ 2021-03-26 6:13 Zheng Yongjun
2021-03-26 6:38 ` Greg Kroah-Hartman
0 siblings, 1 reply; 3+ messages in thread
From: Zheng Yongjun @ 2021-03-26 6:13 UTC (permalink / raw)
To: zhengyongjun3, Greg Kroah-Hartman, Andrey Konovalov,
Dmitry Vyukov, Masahiro Yamada, Sebastian Andrzej Siewior,
Ahmed S. Darwish, Gustavo A. R. Silva, Sasha Levin, Allen Pais
Cc: linux-usb, kernel-janitors, Hulk Robot
Remove including <linux/version.h> that don't need it.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
---
drivers/usb/core/hcd.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
index 3f0381344221..53bc93d6eb0c 100644
--- a/drivers/usb/core/hcd.c
+++ b/drivers/usb/core/hcd.c
@@ -11,7 +11,6 @@
#include <linux/bcd.h>
#include <linux/module.h>
-#include <linux/version.h>
#include <linux/kernel.h>
#include <linux/sched/task_stack.h>
#include <linux/slab.h>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] usb: remove unused including <linux/version.h>
2021-03-26 6:13 [PATCH -next] usb: remove unused including <linux/version.h> Zheng Yongjun
@ 2021-03-26 6:38 ` Greg Kroah-Hartman
2021-03-26 6:43 ` 答复: " zhengyongjun
0 siblings, 1 reply; 3+ messages in thread
From: Greg Kroah-Hartman @ 2021-03-26 6:38 UTC (permalink / raw)
To: Zheng Yongjun
Cc: Andrey Konovalov, Dmitry Vyukov, Masahiro Yamada,
Sebastian Andrzej Siewior, Ahmed S. Darwish, Gustavo A. R. Silva,
Sasha Levin, Allen Pais, linux-usb, kernel-janitors, Hulk Robot
On Fri, Mar 26, 2021 at 02:13:26PM +0800, Zheng Yongjun wrote:
> Remove including <linux/version.h> that don't need it.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
> ---
> drivers/usb/core/hcd.c | 1 -
> 1 file changed, 1 deletion(-)
> diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
> index 3f0381344221..53bc93d6eb0c 100644
> --- a/drivers/usb/core/hcd.c
> +++ b/drivers/usb/core/hcd.c
> @@ -11,7 +11,6 @@
> #include <linux/bcd.h>
> #include <linux/module.h>
> -#include <linux/version.h>
> #include <linux/kernel.h>
> #include <linux/sched/task_stack.h>
> #include <linux/slab.h>
>
Your tool is VERY broken. Please stop sending patches that you
obviously do not even test before submitting:
https://lore.kernel.org/r/1614733752-56541-1-git-send-email-tiantao6@hisilicon.com
It's a sure way to make maintainers very grumpy.
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* 答复: [PATCH -next] usb: remove unused including <linux/version.h>
2021-03-26 6:38 ` Greg Kroah-Hartman
@ 2021-03-26 6:43 ` zhengyongjun
0 siblings, 0 replies; 3+ messages in thread
From: zhengyongjun @ 2021-03-26 6:43 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Andrey Konovalov, Dmitry Vyukov, Masahiro Yamada,
Sebastian Andrzej Siewior, Ahmed S. Darwish, Gustavo A. R. Silva,
Sasha Levin, Allen Pais, linux-usb@vger.kernel.org,
kernel-janitors@vger.kernel.org, pmail_hulkci
Sorry, I will check all my patch later before I send to maintainer and I will stop this patch series.
-----邮件原件-----
发件人: Greg Kroah-Hartman [mailto:gregkh@linuxfoundation.org]
发送时间: 2021年3月26日 14:38
收件人: zhengyongjun <zhengyongjun3@huawei.com>
抄送: Andrey Konovalov <andreyknvl@google.com>; Dmitry Vyukov <dvyukov@google.com>; Masahiro Yamada <masahiroy@kernel.org>; Sebastian Andrzej Siewior <bigeasy@linutronix.de>; Ahmed S. Darwish <a.darwish@linutronix.de>; Gustavo A. R. Silva <gustavoars@kernel.org>; Sasha Levin <sashal@kernel.org>; Allen Pais <allen.lkml@gmail.com>; linux-usb@vger.kernel.org; kernel-janitors@vger.kernel.org; pmail_hulkci <hulkci@huawei.com>
主题: Re: [PATCH -next] usb: remove unused including <linux/version.h>
On Fri, Mar 26, 2021 at 02:13:26PM +0800, Zheng Yongjun wrote:
> Remove including <linux/version.h> that don't need it.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
> ---
> drivers/usb/core/hcd.c | 1 -
> 1 file changed, 1 deletion(-)
> diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c index
> 3f0381344221..53bc93d6eb0c 100644
> --- a/drivers/usb/core/hcd.c
> +++ b/drivers/usb/core/hcd.c
> @@ -11,7 +11,6 @@
> #include <linux/bcd.h>
> #include <linux/module.h>
> -#include <linux/version.h>
> #include <linux/kernel.h>
> #include <linux/sched/task_stack.h>
> #include <linux/slab.h>
>
Your tool is VERY broken. Please stop sending patches that you obviously do not even test before submitting:
https://lore.kernel.org/r/1614733752-56541-1-git-send-email-tiantao6@hisilicon.com
It's a sure way to make maintainers very grumpy.
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-26 6:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-26 6:13 [PATCH -next] usb: remove unused including <linux/version.h> Zheng Yongjun
2021-03-26 6:38 ` Greg Kroah-Hartman
2021-03-26 6:43 ` 答复: " zhengyongjun
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).