From: Greg KH <gregkh@linuxfoundation.org>
To: Ray Chi <raychi@google.com>
Cc: balbi@kernel.org, Thinh.Nguyen@synopsys.com,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
albertccwang@google.com
Subject: Re: [Patch v3] usb: dwc3: add cancelled reasons for dwc3 requests
Date: Sat, 27 Mar 2021 14:35:27 +0100 [thread overview]
Message-ID: <YF80n+iN9zYYooOB@kroah.com> (raw)
In-Reply-To: <20210327132202.1759953-1-raychi@google.com>
On Sat, Mar 27, 2021 at 09:22:02PM +0800, Ray Chi wrote:
> Currently, when dwc3 handles request cancelled, dwc3 just returns
> -ECONNRESET for all requests. It will cause USB function drivers
> can't know if the requests are cancelled by other reasons.
>
> This patch will replace DWC3_REQUEST_STATUS_CANCELLED with the
> reasons below.
> - DWC3_REQUEST_STATUS_DISCONNECTED
> - DWC3_REQUEST_STATUS_DEQUEUED
> - DWC3_REQUEST_STATUS_STALLED
>
> Signed-off-by: Ray Chi <raychi@google.com>
> ---
> drivers/usb/dwc3/core.h | 12 +++++++-----
> drivers/usb/dwc3/gadget.c | 24 ++++++++++++++++++++----
> drivers/usb/dwc3/gadget.h | 6 ++++--
> 3 files changed, 31 insertions(+), 11 deletions(-)
What changed from the previous versions? that should always go below
the --- line as documented.
Please fix up and submit a v4 with that information.
thanks,
greg k-h
prev parent reply other threads:[~2021-03-27 13:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-27 13:22 [Patch v3] usb: dwc3: add cancelled reasons for dwc3 requests Ray Chi
2021-03-27 13:35 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YF80n+iN9zYYooOB@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Thinh.Nguyen@synopsys.com \
--cc=albertccwang@google.com \
--cc=balbi@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=raychi@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).