From: Greg KH <gregkh@linuxfoundation.org>
To: Longfang Liu <liulongfang@huawei.com>
Cc: mathias.nyman@intel.com, stern@rowland.harvard.edu,
liudongdong3@huawei.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, kong.kongxinwei@hisilicon.com,
yisen.zhuang@huawei.com
Subject: Re: [PATCH v2 1/2] USB:ehci:Add a whitelist for EHCI controllers
Date: Thu, 8 Apr 2021 16:53:08 +0200 [thread overview]
Message-ID: <YG8Y1HexwyN2Wk03@kroah.com> (raw)
In-Reply-To: <1617889760-17733-2-git-send-email-liulongfang@huawei.com>
On Thu, Apr 08, 2021 at 09:49:19PM +0800, Longfang Liu wrote:
> Some types of EHCI controllers do not have SBRN registers.
> By comparing the white list, the operation of reading the SBRN
> registers is skipped.
>
> Subsequent EHCI controller types without SBRN registers can be
> directly added to the white list.
>
> The current patch does not affect the drive function.
>
> Signed-off-by: Longfang Liu <liulongfang@huawei.com>
> ---
> drivers/usb/host/ehci-pci.c | 28 ++++++++++++++++++++++++----
> 1 file changed, 24 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/host/ehci-pci.c b/drivers/usb/host/ehci-pci.c
> index 3c3820a..534e906 100644
> --- a/drivers/usb/host/ehci-pci.c
> +++ b/drivers/usb/host/ehci-pci.c
> @@ -47,6 +47,29 @@ static inline bool is_bypassed_id(struct pci_dev *pdev)
> return !!pci_match_id(bypass_pci_id_table, pdev);
> }
>
> +static const struct usb_nosbrn_whitelist_entry {
Again, please do not use the term "whitelist", it is vague and you can
pick a better term for this.
How about:
struct ehci_nosbrn;
thanks,
greg k-h
next prev parent reply other threads:[~2021-04-08 14:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 13:49 [PATCH v2 0/2] USB:ehci:fix the no SRBN register problem Longfang Liu
2021-04-08 13:49 ` [PATCH v2 1/2] USB:ehci:Add a whitelist for EHCI controllers Longfang Liu
2021-04-08 14:53 ` Greg KH [this message]
2021-04-08 17:30 ` kernel test robot
2021-04-08 20:34 ` kernel test robot
2021-04-08 13:49 ` [PATCH v2 2/2] USB:ehci:fix Kunpeng920 ehci hardware problem Longfang Liu
2021-04-08 14:53 ` [PATCH v2 0/2] USB:ehci:fix the no SRBN register problem Alan Stern
2021-04-09 2:42 ` liulongfang
2021-04-09 6:47 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YG8Y1HexwyN2Wk03@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=kong.kongxinwei@hisilicon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=liudongdong3@huawei.com \
--cc=liulongfang@huawei.com \
--cc=mathias.nyman@intel.com \
--cc=stern@rowland.harvard.edu \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox