From: Greg KH <gregkh@linuxfoundation.org>
To: cristian.birsan@microchip.com
Cc: linux@roeck-us.net, heikki.krogerus@linux.intel.com,
robh+dt@kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [RFC PATCH v2 0/2] usb: typec: Add driver for Microchip sama7g5 tcpc
Date: Wed, 31 Mar 2021 08:21:46 +0200 [thread overview]
Message-ID: <YGQU+g8J6gZhn13X@kroah.com> (raw)
In-Reply-To: <20210330205442.981649-1-cristian.birsan@microchip.com>
On Tue, Mar 30, 2021 at 11:54:40PM +0300, cristian.birsan@microchip.com wrote:
> From: Cristian Birsan <cristian.birsan@microchip.com>
>
> This patch set adds initial driver support for Microchip USB Type-C Port
> Controller (TCPC) embedded in sama7g5 SoC.
>
> The controller does not implement power delivery and the driver uses dummy
> functions to register the port with TCPM. The current silicon version is
> not able to trigger interrupts so the driver will poll for changes on
> CC1/CC2 lines.
>
> Support for sink is implemented and tested with an USB device. The plan is
> to extend the driver and add source support.
Why are these marked "RFC"?
Do you really not think they should be accepted? Why not, what is left
to do with them?
I do not normally review "RFC" patches as the authors do not think they
should be merged, and we have plenty of patches that are being asked to
be merged already :)
thanks,
greg k-h
next prev parent reply other threads:[~2021-03-31 6:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 20:54 [RFC PATCH v2 0/2] usb: typec: Add driver for Microchip sama7g5 tcpc cristian.birsan
2021-03-30 20:54 ` [RFC PATCH v2 1/2] dt-bindings: usb: Add DT bindings " cristian.birsan
2021-04-01 17:16 ` Rob Herring
2021-03-30 20:54 ` [RFC PATCH v2 2/2] usb: typec: sama7g5_tcpc: add driver " cristian.birsan
2021-03-31 8:45 ` Heikki Krogerus
2021-03-31 6:21 ` Greg KH [this message]
2021-03-31 19:41 ` [RFC PATCH v2 0/2] usb: typec: Add " Cristian.Birsan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YGQU+g8J6gZhn13X@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=cristian.birsan@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).