From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01FF3C433B4 for ; Tue, 6 Apr 2021 14:14:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BFB5C613A7 for ; Tue, 6 Apr 2021 14:14:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344956AbhDFOPC (ORCPT ); Tue, 6 Apr 2021 10:15:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:41074 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244364AbhDFOO5 (ORCPT ); Tue, 6 Apr 2021 10:14:57 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0E84A61382; Tue, 6 Apr 2021 14:14:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1617718489; bh=INz753g/rP6LpFipcHZBYmnDy3NFV9T5EzJWjxWQUkc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ruMciBRyJxZwyxh8uc/3tSywGv/2V4c4b2rk1kxagDSHiad5LFNGJ9oqoS4jqlqZy TJSSLH1dob+YrSSlkITZk/sdzQDNYEBvmQi9aCE96Ee1HxJ0asYeOe2IBAcJkEsyvv TXVknqxlmYX51sx4I9EKshKoj93eShjsPV1l/dtk= Date: Tue, 6 Apr 2021 16:14:42 +0200 From: Greg Kroah-Hartman To: Badhri Jagan Sridharan Cc: Guenter Roeck , Heikki Krogerus , Rob Herring , Adam Thomson , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Kyle Tso Subject: Re: [PATCH v1 2/6] usb: typec: tcpm: Address incorrect values of tcpm psy for pps supply Message-ID: References: <20210406013643.3280369-1-badhri@google.com> <20210406013643.3280369-3-badhri@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210406013643.3280369-3-badhri@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Mon, Apr 05, 2021 at 06:36:39PM -0700, Badhri Jagan Sridharan wrote: > tcpm_pd_select_pps_apdo overwrites port->pps_data.min_volt, > port->pps_data.max_volt, port->pps_data.max_curr even before > port partner accepts the requests. This leaves incorrect values > in current_limit and supply_voltage that get exported by > "tcpm-source-psy-". Solving this problem by caching the request > values in req_min_volt, req_max_volt, req_max_curr, req_out_volt, > req_op_curr. min_volt, max_volt, max_curr gets updated once the > partner accepts the request. current_limit, supply_voltage gets updated > once local port's tcpm enters SNK_TRANSITION_SINK when the accepted > current_limit and supply_voltage is enforced. > > Fixes: f2a8aa053c176 ("typec: tcpm: Represent source supply through power_supply") > Signed-off-by: Badhri Jagan Sridharan > --- > drivers/usb/typec/tcpm/tcpm.c | 84 ++++++++++++++++++++--------------- > 1 file changed, 49 insertions(+), 35 deletions(-) > > diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c > index 03eca5061132..d43774cc2ccf 100644 > --- a/drivers/usb/typec/tcpm/tcpm.c > +++ b/drivers/usb/typec/tcpm/tcpm.c > @@ -269,11 +269,22 @@ struct pd_mode_data { > }; > > struct pd_pps_data { > + /* Actual min voltage at the local port */ > u32 min_volt; > + /* Requested min voltage to the port partner */ > + u32 req_min_volt; > + /* Actual max voltage at the local port */ > u32 max_volt; > + /* Requested max voltage to the port partner */ > + u32 req_max_volt; > + /* Actual max current at the local port */ > u32 max_curr; > - u32 out_volt; > - u32 op_curr; > + /* Requested max current of the port partner */ > + u32 req_max_curr; > + /* Requested output voltage to the port partner */ > + u32 req_out_volt; > + /* Requested operating current to the port partner */ > + u32 req_op_curr; Shouldn't you just document this all properly in a kerneldoc header right above the structure? thanks, greg k-h