From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0617CC433B4 for ; Tue, 13 Apr 2021 10:24:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D3661613BD for ; Tue, 13 Apr 2021 10:24:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231325AbhDMKZQ (ORCPT ); Tue, 13 Apr 2021 06:25:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:44162 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230088AbhDMKZQ (ORCPT ); Tue, 13 Apr 2021 06:25:16 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 266A6613BC; Tue, 13 Apr 2021 10:24:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1618309495; bh=ONbuNQKp4fLe2bXBPC0OBnwwqYpiefNv8y21f4kKdvQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vMn9xkkjtmrWuorc5uSelPm2QrS+0jAN9sEyslN3+Wac72MPnsWzYwQpT64qjE1x6 0LEaGRZmMHFdgPjsOVOpp9WwSIXrJd91lpoiipqpZV39NBecaOIo4ZFryDpwu91DV6 Uc1FXC0/ZxIX8y9seQrHLp09QBGPQJGUQ5uwcrVU= Date: Tue, 13 Apr 2021 12:24:53 +0200 From: Greg Kroah-Hartman To: Sergei Shtylyov Cc: Artur Petrosyan , Felipe Balbi , Minas Harutyunyan , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, John Youn Subject: Re: [PATCH 07/12] usb: dwc2: Update enter clock gating when port is suspended Message-ID: References: <9ed1da9780cddf995841cc5867f195024f5a16d9.1618297800.git.Arthur.Petrosyan@synopsys.com> <2dc3798a-6a89-b363-aade-e127decfdf20@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2dc3798a-6a89-b363-aade-e127decfdf20@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Tue, Apr 13, 2021 at 12:22:35PM +0300, Sergei Shtylyov wrote: > Hello! > > On 13.04.2021 10:17, Artur Petrosyan wrote: > > > Updates the implementation of entering clock gating mode > > when core receives port suspend. > > Instead of setting the required bit fields of the registers > > inline, called the "dwc2_host_enter_clock_gating()" function. > > > > Signed-off-by: Artur Petrosyan > > --- > > drivers/usb/dwc2/hcd.c | 19 ++++--------------- > > 1 file changed, 4 insertions(+), 15 deletions(-) > > > > diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c > > index 27f030d5de54..e1225fe6c61a 100644 > > --- a/drivers/usb/dwc2/hcd.c > > +++ b/drivers/usb/dwc2/hcd.c > [...] > > @@ -3323,22 +3322,12 @@ int dwc2_port_suspend(struct dwc2_hsotg *hsotg, u16 windex) > > break; > > case DWC2_POWER_DOWN_PARAM_HIBERNATION: > > case DWC2_POWER_DOWN_PARAM_NONE: > > - default: > > - hprt0 = dwc2_read_hprt0(hsotg); > > - hprt0 |= HPRT0_SUSP; > > - dwc2_writel(hsotg, hprt0, HPRT0); > > - hsotg->bus_suspended = true; > > /* > > - * If power_down is supported, Phy clock will be suspended > > - * after registers are backuped. > > + * If not hibernation nor partial power down are supported, > > s/not/neither/? It's fine, not a big deal at all. greg k-h