From: Greg KH <gregkh@linuxfoundation.org>
To: Malte Deiseroth <msdeiseroth@gmx.net>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: Fix missing whitespace in function calls.
Date: Fri, 16 Apr 2021 07:15:23 +0200 [thread overview]
Message-ID: <YHkdayDVPvNF9yal@kroah.com> (raw)
In-Reply-To: <20210415203106.GA122777@utop>
On Thu, Apr 15, 2021 at 10:31:06PM +0200, Malte Deiseroth wrote:
> Signed-off-by: Malte Deiseroth <mdeiseroth88@gmail.com>
> ---
> drivers/usb/misc/adutux.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/misc/adutux.c b/drivers/usb/misc/adutux.c
> index 45a387979935..6d15a097b007 100644
> --- a/drivers/usb/misc/adutux.c
> +++ b/drivers/usb/misc/adutux.c
> @@ -183,10 +183,10 @@ static void adu_interrupt_in_callback(struct urb *urb)
> dev->interrupt_in_buffer, urb->actual_length);
>
> dev->read_buffer_length += urb->actual_length;
> - dev_dbg(&dev->udev->dev,"%s reading %d\n", __func__,
> + dev_dbg(&dev->udev->dev, "%s reading %d\n", __func__,
> urb->actual_length);
> } else {
> - dev_dbg(&dev->udev->dev,"%s : read_buffer overflow\n",
> + dev_dbg(&dev->udev->dev, "%s : read_buffer overflow\n",
> __func__);
> }
> }
> @@ -726,7 +726,7 @@ static int adu_probe(struct usb_interface *interface,
> retval = -EIO;
> goto error;
> }
> - dev_dbg(&interface->dev,"serial_number=%s", dev->serial_number);
> + dev_dbg(&interface->dev, "serial_number=%s", dev->serial_number);
>
> /* we can register the device now, as it is ready */
> usb_set_intfdata(interface, dev);
> --
> 2.27.0
>
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.
You are receiving this message because of the following common error(s)
as indicated below:
- You did not specify a description of why the patch is needed, or
possibly, any description at all, in the email body. Please read the
section entitled "The canonical patch format" in the kernel file,
Documentation/SubmittingPatches for what is needed in order to
properly describe the change.
- You did not write a descriptive Subject: for the patch, allowing Greg,
and everyone else, to know what this patch is all about. Please read
the section entitled "The canonical patch format" in the kernel file,
Documentation/SubmittingPatches for what a proper Subject: line should
look like.
- It looks like you did not use your "real" name for the patch on either
the Signed-off-by: line, or the From: line (both of which have to
match). Please read the kernel file, Documentation/SubmittingPatches
for how to do this correctly.
If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.
thanks,
greg k-h's patch email bot
prev parent reply other threads:[~2021-04-16 5:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-15 20:31 [PATCH] usb: Fix missing whitespace in function calls Malte Deiseroth
2021-04-16 5:15 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YHkdayDVPvNF9yal@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=msdeiseroth@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox