From: Johan Hovold <johan@kernel.org>
To: Leonardo Antoniazzi <leoanto@aruba.it>
Cc: linux-usb@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Anirudh Rayabharam <mail@anirudhrb.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: hso: fix NULL-deref on disconnect regression
Date: Mon, 26 Apr 2021 11:35:46 +0200 [thread overview]
Message-ID: <YIaJcgmiJFERvbEF@hovoldconsulting.com> (raw)
In-Reply-To: <20210426112911.fb3593c3a9ecbabf98a13313@aruba.it>
On Mon, Apr 26, 2021 at 11:29:11AM +0200, Leonardo Antoniazzi wrote:
> On Mon, 26 Apr 2021 10:11:49 +0200
> Johan Hovold <johan@kernel.org> wrote:
>
> > Commit 8a12f8836145 ("net: hso: fix null-ptr-deref during tty device
> > unregistration") fixed the racy minor allocation reported by syzbot, but
> > introduced an unconditional NULL-pointer dereference on every disconnect
> > instead.
> >
> > Specifically, the serial device table must no longer be accessed after
> > the minor has been released by hso_serial_tty_unregister().
> >
> > Fixes: 8a12f8836145 ("net: hso: fix null-ptr-deref during tty device unregistration")
> > Cc: stable@vger.kernel.org
> > Cc: Anirudh Rayabharam <mail@anirudhrb.com>
> > Reported-by: Leonardo Antoniazzi <leoanto@aruba.it>
> > Signed-off-by: Johan Hovold <johan@kernel.org>
> > ---
> the patch fix the problem
Thanks for confirming.
Next time, please keep the CC list intact when replying so that everyone
sees that you've tested it.
Johan
next prev parent reply other threads:[~2021-04-26 9:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-26 8:11 [PATCH] net: hso: fix NULL-deref on disconnect regression Johan Hovold
2021-04-26 9:29 ` Leonardo Antoniazzi
2021-04-26 9:35 ` Johan Hovold [this message]
2021-04-26 9:50 ` Greg Kroah-Hartman
2021-04-26 20:09 ` David Miller
2021-04-27 6:11 ` Greg KH
2021-04-26 14:01 ` Anirudh Rayabharam
2021-04-26 20:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YIaJcgmiJFERvbEF@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=kuba@kernel.org \
--cc=leoanto@aruba.it \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mail@anirudhrb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox