Re: [PATCH 1/3] usb: xhci-mtk: use bitfield instead of bool

Chunfeng Yun
2021-05-06T06:28:51Z

On Fri, 2021-04-30 at 09:29 +0200, Greg Kroah-Hartman wrote:
> On Fri, Apr 30, 2021 at 03:15:30PM +0800, Chunfeng Yun wrote:
> > Use bitfield instead of bool in struct
>
> That says what you did, but not why you did it.
>
> Why?
It's suggested by "Using bool" in coding-style.rst, I'll add it
>
> >
> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> > ---
> > drivers/usb/host/xhci-mtk.c | 2 --
> > drivers/usb/host/xhci-mtk.h | 8 ++++----
> > 2 files changed, 4 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/usb/host/xhci-mtk.c b/drivers/usb/host/xhci-mtk.c
> > index b2058b3bc834..2548976bcf05 100644
> > --- a/drivers/usb/host/xhci-mtk.c
> > +++ b/drivers/usb/host/xhci-mtk.c
> > @@ -495,8 +495,6 @@ static int xhci_mtk_probe(struct platform_device *pdev)
> > goto put_usb2_hcd;
> > }
> > mtk->has_ippc = true;
> > - } else {
> > - mtk->has_ippc = false;
>
> Why did you remove this chunk? That is not described in the changelog
> at all.
Will add it, thank you

>
> thanks,
>
> greg k-h