* [PATCH -next] USB: EHCI: ehci-mv: add missing MODULE_DEVICE_TABLE
@ 2021-05-12 6:36 Zou Wei
2021-05-12 15:08 ` Alan Stern
2021-05-13 13:59 ` Greg KH
0 siblings, 2 replies; 3+ messages in thread
From: Zou Wei @ 2021-05-12 6:36 UTC (permalink / raw)
To: stern, gregkh; +Cc: linux-usb, linux-kernel, Zou Wei
This patch adds missing MODULE_DEVICE_TABLE definition which generates
correct modalias for automatic loading of this driver when it is built
as an external module.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
---
drivers/usb/host/ehci-mv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/host/ehci-mv.c b/drivers/usb/host/ehci-mv.c
index cffdc8d..beb478c 100644
--- a/drivers/usb/host/ehci-mv.c
+++ b/drivers/usb/host/ehci-mv.c
@@ -266,6 +266,7 @@ static const struct platform_device_id ehci_id_table[] = {
{"pxa-sph", 0},
{},
};
+MODULE_DEVICE_TABLE(platform, ehci_id_table);
static void mv_ehci_shutdown(struct platform_device *pdev)
{
--
2.6.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH -next] USB: EHCI: ehci-mv: add missing MODULE_DEVICE_TABLE
2021-05-12 6:36 [PATCH -next] USB: EHCI: ehci-mv: add missing MODULE_DEVICE_TABLE Zou Wei
@ 2021-05-12 15:08 ` Alan Stern
2021-05-13 13:59 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Alan Stern @ 2021-05-12 15:08 UTC (permalink / raw)
To: Zou Wei; +Cc: gregkh, linux-usb, linux-kernel
On Wed, May 12, 2021 at 02:36:09PM +0800, Zou Wei wrote:
> This patch adds missing MODULE_DEVICE_TABLE definition which generates
> correct modalias for automatic loading of this driver when it is built
> as an external module.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
> ---
> drivers/usb/host/ehci-mv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/host/ehci-mv.c b/drivers/usb/host/ehci-mv.c
> index cffdc8d..beb478c 100644
> --- a/drivers/usb/host/ehci-mv.c
> +++ b/drivers/usb/host/ehci-mv.c
> @@ -266,6 +266,7 @@ static const struct platform_device_id ehci_id_table[] = {
> {"pxa-sph", 0},
> {},
> };
> +MODULE_DEVICE_TABLE(platform, ehci_id_table);
>
> static void mv_ehci_shutdown(struct platform_device *pdev)
> {
This is a bit odd. Nothing wrong with it, of course, but it leads one
to wonder how the driver ever worked. Maybe the platforms that can use
it never build the driver as a loadable module.
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Alan Stern
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] USB: EHCI: ehci-mv: add missing MODULE_DEVICE_TABLE
2021-05-12 6:36 [PATCH -next] USB: EHCI: ehci-mv: add missing MODULE_DEVICE_TABLE Zou Wei
2021-05-12 15:08 ` Alan Stern
@ 2021-05-13 13:59 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2021-05-13 13:59 UTC (permalink / raw)
To: Zou Wei; +Cc: stern, linux-usb, linux-kernel
On Wed, May 12, 2021 at 02:36:09PM +0800, Zou Wei wrote:
> This patch adds missing MODULE_DEVICE_TABLE definition which generates
> correct modalias for automatic loading of this driver when it is built
> as an external module.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
> ---
> drivers/usb/host/ehci-mv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/host/ehci-mv.c b/drivers/usb/host/ehci-mv.c
> index cffdc8d..beb478c 100644
> --- a/drivers/usb/host/ehci-mv.c
> +++ b/drivers/usb/host/ehci-mv.c
> @@ -266,6 +266,7 @@ static const struct platform_device_id ehci_id_table[] = {
> {"pxa-sph", 0},
> {},
> };
> +MODULE_DEVICE_TABLE(platform, ehci_id_table);
As I said elsewhere, I'm not taking these unless you can show a reason
why they are needed.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-13 13:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-05-12 6:36 [PATCH -next] USB: EHCI: ehci-mv: add missing MODULE_DEVICE_TABLE Zou Wei
2021-05-12 15:08 ` Alan Stern
2021-05-13 13:59 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).