Re: Re: [PATCH] HID: usbhid: enable remote wakeup for mouse

Greg KH
2021-05-17T09:46:04Z

On Mon, May 17, 2021 at 05:37:54PM +0800, 马强 wrote:
>
> >> This patch enables remote wakeup by default for USB mouse
> >> devices. Mouse in general are supposed to be wakeup devices, but
> >> the correct place to enable it depends on the device's bus; no single
> >> approach will work for all mouse devices. In particular, this
> >> covers only USB mouse (and then only those supporting the boot
> >> protocol).
> >>
> >> Signed-off-by: Qiang Ma <maqianga@uniontech.com>
>
> > Based on hardware testing, I do not think we can do this as no other
> > operating system does this, right? It's not a requirement of the USB
> > specification to support this, so we can not enforce it either.
>
>
> Thanks for the prompt response.
>
> We can change "dev->power.should_wakeup" to enabled,

I do not understand this statement.

> but ultimately it depends on the hardware and BIOS for wakeup.

Yes, and the hardware here (USB mice), do not all support this, so you
can not enable it universally as it will cause problems, right?

thanks,

greg k-h