Re: Re: Re: Re: Re: [PATCH] HID: usbhid: enable remote wakeup for mouse

Greg KH
2021-05-17T11:44:17Z

On Mon, May 17, 2021 at 07:28:15PM +0800, 马强 wrote:
>
> > Given that you have not tested this change, why should we take this?
>
>
> I have tested this change.
>
> Before adding the patch, "dev->power.should_wakeup" is disabled after the
> insertion of the USB mouse,
>
> and after adding the patch, "dev->power.should_wakeup" is enabled after the
> insertion of the USB mouse.
>
>
>
>

How many different mice did you test this on? What specific models?

Again, this is not a requirement of all Mice devices, as it is not a
requirement of the USB specification, which is why we can not enable it
for all devices of this type.

And no other operating system does so either that I know of. Do you
know of one?

thanks,

greg k-h