Re: [PATCH] HID: usbhid: enable remote wakeup for mouse

Alan Stern
2021-05-17T13:32:54Z

On Mon, May 17, 2021 at 10:31:45AM +0200, Oliver Neukum wrote:
> Am Montag, den 17.05.2021, 14:01 +0800 schrieb Qiang Ma:
> > This patch enables remote wakeup by default for USB mouse
> > devices. Mouse in general are supposed to be wakeup devices, but

I disagree with that statement. Who decided that mice are supposed to
be wakeup devices?

> > the correct place to enable it depends on the device's bus; no single
> > approach will work for all mouse devices. In particular, this
> > covers only USB mouse (and then only those supporting the boot
> > protocol).
> >
>
> Hi,
>
> have you tested this? In my experience the issue with mice
> is that they wake up only when you press a mouse button, not when you
> move the mouse. Do we make a promise we cannot keep here?

Even worse, if a mouse is enabled for wakeup then the system may get
woken up at the wrong time. The example people often use is a laptop
with a USB mouse thrown into a backpack while it is asleep. Something
else inside the backpack may accidentally press against a mouse button,
causing the system to wake up even though the user wants it to remain
asleep.

Alan Stern