From: Greg KH <gregkh@linuxfoundation.org>
To: "Geoffrey D. Bennett" <g@b4.vu>
Cc: USB mailing list <linux-usb@vger.kernel.org>,
Alan Stern <stern@rowland.harvard.edu>
Subject: Re: [PATCH] USB: usbfs: remove double evaluation of usb_sndctrlpipe()
Date: Fri, 21 May 2021 15:17:30 +0200 [thread overview]
Message-ID: <YKey6h3njaT7gfCI@kroah.com> (raw)
In-Reply-To: <20210521125856.116349-1-g@b4.vu>
On Fri, May 21, 2021 at 10:28:56PM +0930, Geoffrey D. Bennett wrote:
> usb_sndctrlpipe() is evaluated in do_proc_control(), saved in a
> variable, then evaluated again. Use the saved variable instead, to
> match the use of usb_rcvctrlpipe().
>
> Fixes: 4c6e8971cbe0 ("USB: make the "usbfs_snoop" log more pertinent")
There is no bug here to "fix" this is just a cleanup.
Can you drop this and then properly cc: the needed developers when you
resend a v2?
thanks,
greg k-h
next prev parent reply other threads:[~2021-05-21 13:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-21 12:58 [PATCH] USB: usbfs: remove double evaluation of usb_sndctrlpipe() Geoffrey D. Bennett
2021-05-21 13:17 ` Greg KH [this message]
2021-05-21 14:39 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKey6h3njaT7gfCI@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=g@b4.vu \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox