From: Johan Hovold <johan@kernel.org>
To: Alexandre GRIVEAUX <agriveaux@deutnet.info>
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND 2/2] USB: serial: omninet: Renaming driver to Zyxel omni.net
Date: Tue, 25 May 2021 09:03:26 +0200 [thread overview]
Message-ID: <YKyhPtVUwdGdXAoq@hovoldconsulting.com> (raw)
In-Reply-To: <20210523163522.1690-2-agriveaux@deutnet.info>
On Sun, May 23, 2021 at 06:35:22PM +0200, Alexandre GRIVEAUX wrote:
> With the inclusion of Omni 56K Plus, this driver seem to be more common
> among the family of Zyxel omni modem.
I amended the commit message to make it more clear that you're updating
the driver and module descriptions and not really renaming the driver.
> Signed-off-by: Alexandre GRIVEAUX <agriveaux@deutnet.info>
> ---
> drivers/usb/serial/omninet.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/serial/omninet.c b/drivers/usb/serial/omninet.c
> index 8be91f5a4dd7..79c0dab46ae8 100644
> --- a/drivers/usb/serial/omninet.c
> +++ b/drivers/usb/serial/omninet.c
> @@ -1,6 +1,6 @@
> // SPDX-License-Identifier: GPL-2.0
> /*
> - * USB ZyXEL omni.net LCD PLUS driver
> + * USB ZyXEL omni.net driver
> *
> * Copyright (C) 2013,2017 Johan Hovold <johan@kernel.org>
> *
> @@ -22,7 +22,7 @@
> #include <linux/usb/serial.h>
>
> #define DRIVER_AUTHOR "Alessandro Zummo"
> -#define DRIVER_DESC "USB ZyXEL omni.net LCD PLUS Driver"
> +#define DRIVER_DESC "USB ZyXEL omni.net Driver"
>
> #define ZYXEL_VENDOR_ID 0x0586
> #define ZYXEL_OMNINET_ID 0x1000
> @@ -52,7 +52,7 @@ static struct usb_serial_driver zyxel_omninet_device = {
> .owner = THIS_MODULE,
> .name = "omninet",
> },
> - .description = "ZyXEL - omni.net lcd plus usb",
> + .description = "ZyXEL - omni.net usb",
> .id_table = id_table,
> .num_bulk_out = 2,
> .calc_num_ports = omninet_calc_num_ports,
Now applied.
Johan
next prev parent reply other threads:[~2021-05-25 7:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-23 16:35 [PATCH RESEND 1/2] USB: serial: omninet: Adding Zyxel Omni 56K Plus Alexandre GRIVEAUX
2021-05-23 16:35 ` [PATCH RESEND 2/2] USB: serial: omninet: Renaming driver to Zyxel omni.net Alexandre GRIVEAUX
2021-05-25 7:03 ` Johan Hovold [this message]
2021-05-25 7:01 ` [PATCH RESEND 1/2] USB: serial: omninet: Adding Zyxel Omni 56K Plus Johan Hovold
2021-05-25 9:25 ` Alexandre GRIVEAUX
2021-05-26 7:52 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKyhPtVUwdGdXAoq@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=agriveaux@deutnet.info \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox