From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C31EEC4743F for ; Mon, 7 Jun 2021 09:25:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B227960232 for ; Mon, 7 Jun 2021 09:25:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230411AbhFGJ06 (ORCPT ); Mon, 7 Jun 2021 05:26:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41928 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229966AbhFGJ06 (ORCPT ); Mon, 7 Jun 2021 05:26:58 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1DEC9C061766; Mon, 7 Jun 2021 02:25:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=mJFWyvVpJyGj+OAcSDuHr0rmetUi1/qBDaXb3QbiA1c=; b=joJUtBIfolUhyPQvaZZcvm4Dmk KssSIVJNHCr5rt2OmIXXnTwgzxiTWDrat0S9MgQXQhsWGpX+l5yh1wCMOSjPUZXC77rLNCoXrYg9M 8hDHlMcyH7/jQknJAsHC3BLwBYzs9KSu7qCTbHxAF2EOiJuP1WK1XlaRUG62OaCZuRZcAF5fFKRKE f8Vd5SUaZJmiUM8HfNmlsp8LMI/3hgRz7T71UweN/Z/4uNMwAI9xbqjvgUd1/39tt/Ois1if51zyY re6SehpCObiovNuLhJerIYzajTNKW11MGi70OFhMrTQNiptFrZE8aZI+4rF7a1L2/SfJJS4d45dWl 9jmCy88w==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lqBUs-00FZrq-NB; Mon, 07 Jun 2021 09:24:48 +0000 Date: Mon, 7 Jun 2021 10:24:38 +0100 From: Christoph Hellwig To: Sven Peter Cc: linux-usb@vger.kernel.org, Felipe Balbi , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Arnd Bergmann Subject: Re: [PATCH] usb: dwc3: support 64 bit DMA in platform driver Message-ID: References: <20210606093629.69786-1-sven@svenpeter.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210606093629.69786-1-sven@svenpeter.dev> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Sun, Jun 06, 2021 at 11:36:29AM +0200, Sven Peter wrote: > + /* Try to set 64-bit DMA first */ > + if (WARN_ON(!dwc->sysdev->dma_mask)) > + /* Platform did not initialize dma_mask */ > + ret = dma_coerce_mask_and_coherent(dwc->sysdev, > + DMA_BIT_MASK(64)); > + else > + ret = dma_set_mask_and_coherent(dwc->sysdev, DMA_BIT_MASK(64)); WARN_ON + fallback seems weird. I'd suggest to just error out for the warn case. > + /* If seting 64-bit DMA mask fails, fall back to 32-bit DMA mask */ > + if (ret) { > + ret = dma_set_mask_and_coherent(dwc->sysdev, DMA_BIT_MASK(32)); > + if (ret) > + return ret; > + } Setting a 64-bit mask will not fail. No need for the fallback.