linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Andreas Kemnade <andreas@kemnade.info>
Cc: Bin Liu <b-liu@ti.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, linux-omap@vger.kernel.org,
	letux-kernel@openphoenux.org
Subject: Re: [PATCH] usb: musb: Check devctl status again for a spurious session request
Date: Sun, 6 Jun 2021 09:01:08 +0300	[thread overview]
Message-ID: <YLxkpNdKei2Dc9qV@atomide.com> (raw)
In-Reply-To: <20210605162046.7362a05e@aktux>

* Andreas Kemnade <andreas@kemnade.info> [210605 14:21]:
> On Sat, 5 Jun 2021 08:18:14 +0300
> Tony Lindgren <tony@atomide.com> wrote:
> 
> > * Andreas Kemnade <andreas@kemnade.info> [210604 17:00]:
> > > On Fri, 4 Jun 2021 12:39:54 +0300
> > > Tony Lindgren <tony@atomide.com> wrote:  
> > > > Does the following patch fix things for you or does something else break again? :)
> > > >   
> > > sigh,..
> > > ok, it breaks something. gadget (at least ecm) only works if
> > > musb/phy stuff is loaded, ecm configured via configfs
> > > rmmod omap2430
> > > modprube 2430
> > > 
> > > until the next usb disconnect
> > > and another rmmod/modprobe is required.  
> > 
> > Hmm I don't follow, do you mean there's now another issue after a
> > system suspend? Or is this issue not related to system suspend and
> > resume?
> > 
> independently of suspend.

OK

> > > The following musb patches were applied additional to that one you
> > > added to this mail on top of 5.13-rc4.
> > > 
> > > usb: musb: fix MUSB_QUIRK_B_DISCONNECT_99 handling
> > > usb: musb: Add missing PM suspend and resume functions for 2430 glue
> > > usb: musb: Check devctl status again for a spurious session request  
> > 
> > Does one of the above cause some additional usb gadget issue?
> > 
> I do not see any additional gadget issue just with them. It just starts
> with the small patch you proposed to fix suspend power consumption in
> this thread.

Oh OK, so some more mystery hardware debugging still left to do then.

Regards,

Tony

      reply	other threads:[~2021-06-06  6:01 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-18 15:06 [PATCH] usb: musb: Check devctl status again for a spurious session request Tony Lindgren
2021-05-27 19:15 ` Andreas Kemnade
2021-05-28  5:57   ` Tony Lindgren
2021-05-28  9:37     ` Andreas Kemnade
2021-06-02  5:41       ` Tony Lindgren
2021-06-03 21:22         ` Andreas Kemnade
2021-06-04  8:35     ` Andreas Kemnade
2021-06-04  9:39       ` Tony Lindgren
2021-06-04  9:59         ` Andreas Kemnade
2021-06-04 10:08           ` Tony Lindgren
2021-06-04 10:20             ` Andreas Kemnade
2021-06-04 14:45         ` Andreas Kemnade
2021-06-04 16:59         ` Andreas Kemnade
2021-06-05  5:18           ` Tony Lindgren
2021-06-05 14:20             ` Andreas Kemnade
2021-06-06  6:01               ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YLxkpNdKei2Dc9qV@atomide.com \
    --to=tony@atomide.com \
    --cc=andreas@kemnade.info \
    --cc=b-liu@ti.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=letux-kernel@openphoenux.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).