From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FF23C07E96 for ; Tue, 13 Jul 2021 20:34:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4707161370 for ; Tue, 13 Jul 2021 20:34:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234765AbhGMUg5 (ORCPT ); Tue, 13 Jul 2021 16:36:57 -0400 Received: from mga05.intel.com ([192.55.52.43]:34297 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229944AbhGMUg5 (ORCPT ); Tue, 13 Jul 2021 16:36:57 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10044"; a="295883569" X-IronPort-AV: E=Sophos;i="5.84,237,1620716400"; d="scan'208";a="295883569" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2021 13:34:07 -0700 X-IronPort-AV: E=Sophos;i="5.84,237,1620716400"; d="scan'208";a="459711144" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2021 13:34:04 -0700 Received: from andy by smile with local (Exim 4.94.2) (envelope-from ) id 1m3P6N-00D4nw-8l; Tue, 13 Jul 2021 23:33:59 +0300 Date: Tue, 13 Jul 2021 23:33:59 +0300 From: Andy Shevchenko To: Laurence Oberman Cc: linux-usb@vger.kernel.org, stable@vger.kernel.org, emilne@redhat.com, djeffery@redhat.com, apanagio@redhat.com, torez@redhat.com Subject: Re: [PATCH] usb: hcd: Revert 306c54d0edb6ba94d39877524dddebaad7770cf2: Try MSI interrupts on PCI devices Message-ID: References: <1626202242-14984-1-git-send-email-loberman@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1626202242-14984-1-git-send-email-loberman@redhat.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Tue, Jul 13, 2021 at 02:50:42PM -0400, Laurence Oberman wrote: > Customers have been reporting that the I/O is radically being > slowed down to HPE virtual USB ILO served DVD images during installation. Side note: Simple changing - retval = pci_alloc_irq_vectors(dev, 1, 1, PCI_IRQ_LEGACY | PCI_IRQ_MSI); + retval = pci_alloc_irq_vectors(dev, 1, 1, PCI_IRQ_LEGACY); should have the same effect without touching tons of a good code. -- With Best Regards, Andy Shevchenko