From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-21.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PULL_REQUEST,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76FBBC4338F for ; Sun, 25 Jul 2021 17:03:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5076560C41 for ; Sun, 25 Jul 2021 17:03:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230147AbhGYQX1 (ORCPT ); Sun, 25 Jul 2021 12:23:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:39826 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229709AbhGYQX0 (ORCPT ); Sun, 25 Jul 2021 12:23:26 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9EC2060E77; Sun, 25 Jul 2021 17:03:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1627232636; bh=02MoMRKWlv2NZgcCjtlM5ZQrtjaBj//g6cBpb6EiDVM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MvMKFEBjCWPI6yOqxXIXcMI+DJQ/GIbGFlH51VDE9efMnF4F4QlREYrKGynHu8+rN TW/yWjswVtywGCr2hTHB5+UiRBy1bGsjUoD+1rV+AfH9EO+XUgHpKyitdykGhZlZ2o Yc+flMhMWottx9ERwGgOudKW5My47/cjh/ouGJ0s= Date: Sun, 25 Jul 2021 19:03:53 +0200 From: Greg KH To: Minas Harutyunyan Cc: "linux-usb@vger.kernel.org" Subject: Re: [GIT PULL] USB fixes for 5.14-rc3 Message-ID: References: <970d93d8-38ec-0ff8-6178-825a0698b2ea@synopsys.com> <004e42ef-910e-f426-c777-f246e5bbb61a@synopsys.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <004e42ef-910e-f426-c777-f246e5bbb61a@synopsys.com> Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Sun, Jul 25, 2021 at 04:53:03PM +0000, Minas Harutyunyan wrote: > Hi Greg, > > On 7/25/2021 8:15 PM, Greg KH wrote: > > On Sun, Jul 25, 2021 at 04:05:11PM +0000, Minas Harutyunyan wrote: > >> Hi Greg, > >> On 7/23/2021 6:53 PM, Greg KH wrote: > >>> The following changes since commit e73f0f0ee7541171d89f2e2491130c7771ba58d3: > >>> > >>> Linux 5.14-rc1 (2021-07-11 15:07:40 -0700) > >>> > >>> are available in the Git repository at: > >>> > >>> git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git tags/usb-5.14-rc3 > >>> > >>> for you to fetch changes up to 1d1b97d5e7636d72890a5bdd0b40e980e54b2d34: > >>> > >>> Merge tag 'usb-serial-5.14-rc3' of https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial__;!!A4F2R9G_pg!MJ8qYQZESfA6SADfkbKTOvLpPUIWj9rC0lSEDjqrLPEJjfiuWPCWgzU0Yi_Vb7wC7J3PJwdX$ into usb-linus (2021-07-22 20:51:14 +0200) > >>> > >>> ---------------------------------------------------------------- > >>> USB fixes for 5.14-rc3 > >>> > >>> Here are some USB fixes for 5.14-rc3 to resolve a bunch of tiny problems > >>> reported. Included in here are: > >>> - dtsi revert to resolve a problem which broke android systems > >>> that relied on the dts name to find the USB controller device. > >>> People are still working out the "real" solution for this, but > >>> for now the revert is needed. > >>> - core USB fix for pipe calculation found by syzbot > >>> - typec fixes > >>> - gadget driver fixes > >>> - new usb-serial device ids > >>> - new USB quirks > >>> - xhci fixes > >>> - usb hub fixes for power management issues reported > >>> - other tiny fixes > >>> > >>> All have been in linux-next with no reported problems. > >>> > >>> Signed-off-by: Greg Kroah-Hartman > >>> > >> > >> > >>> > >>> Marek Szyprowski (1): > >>> usb: dwc2: Skip clock gating on Samsung SoCs > >>> > >> > >> I didn't ACK this patch. Me and Marek Szyprowski agreed to discuss > >> details of this patch after he will back from vacation after August 2. > > > > Ok, so should I revert it now that it is in Linus's tree? Did I miss > > the discussion that said there were problems with it? I see an ack for > > the patch, what was wrong with that? > > > Yes, please revert it until we discuss with author details of patch. > Actually I have replied to this patch with some questions and additional > testing request. > Patch was ACKed-by Krzysztof Kozlowski > , but not by me. Sure, but what is wrong with this change? As this fixes a regression, shouldn't it stay in the tree for now? thanks, greg k-h