public inbox for linux-usb@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Maxim Devaev <mdevaev@gmail.com>
Cc: balbi@kernel.org, sandeen@redhat.com, linux-usb@vger.kernel.org,
	Phil Elwell <phil@raspberrypi.com>
Subject: Re: [PATCH] usb: gadget: f_hid: fixed NULL pointer dereference
Date: Fri, 23 Jul 2021 17:52:08 +0200	[thread overview]
Message-ID: <YPrlqBrdCiO2ogxA@kroah.com> (raw)
In-Reply-To: <20210723182203.48396b80@reki>

On Fri, Jul 23, 2021 at 06:22:03PM +0300, Maxim Devaev wrote:
> > Greg KH <gregkh@linuxfoundation.org> writes:
> > Who is the original author here?  Please put their name as the "From:"
> > line in the changelog so we can give proper credit if it was not you.
> 
> Phil Elwell. Fixed.
> 
> > Test for !req and then abort, and then continue on.  No need for moving
> > the copy_from_user line in, right?  Should make the change smaller
> > overall.
> 
> Fixed.
> 
> > Blank line after this please.
> 
> Added.
> 
> > Are the braces still needed here?
> 
> No, you're right.
> 
> Thanks for the review! Here the new version of the patch:
> 
> From 72a504af8e3df3d7a44e9954b8cf03268795c07f Mon Sep 17 00:00:00 2001
> From: Phil Elwell <phil@raspberrypi.com>
> Date: Fri, 23 Jul 2021 11:59:49 +0300
> Subject: [PATCH] usb: gadget: f_hid: fixed NULL pointer dereference

<snip>

Please resend as a v2 in a format that I can apply it in (as a new
email.)

thanks,

greg k-h

  reply	other threads:[~2021-07-23 15:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-23  9:53 [PATCH] usb: gadget: f_hid: fixed NULL pointer dereference Maxim Devaev
2021-07-23 10:14 ` Greg KH
2021-07-23 15:22   ` Maxim Devaev
2021-07-23 15:52     ` Greg KH [this message]
2021-07-23 16:03       ` Maxim Devaev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YPrlqBrdCiO2ogxA@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=balbi@kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mdevaev@gmail.com \
    --cc=phil@raspberrypi.com \
    --cc=sandeen@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox