Re: [PATCH 1/4] PCI: Add AMD USB4 host router device IDs

Mika Westerberg
2021-08-03T09:46:32Z

Hi,

I have one more comment, see below.

On Mon, Aug 02, 2021 at 11:39:32PM +0530, Sanjay R Mehta wrote:
>
>
> On 8/2/2021 8:42 PM, Mika Westerberg wrote:
> > [CAUTION: External Email]
> >
> > On Mon, Aug 02, 2021 at 07:58:17AM -0500, Sanjay R Mehta wrote:
> >> From: Sanjay R Mehta <sanju.mehta@amd.com>
> >>
> >> This patch enables support for AMD USB4 host router.
> >>
> >> Signed-off-by: Basavaraj Natikar <Basavaraj.Natikar@amd.com>
> >> Signed-off-by: Sanjay R Mehta <sanju.mehta@amd.com>
> >> ---
> >> drivers/thunderbolt/nhi.c | 4 ++++
> >> include/linux/pci_ids.h | 2 ++
> >> 2 files changed, 6 insertions(+)
> >>
> >> diff --git a/drivers/thunderbolt/nhi.c b/drivers/thunderbolt/nhi.c
> >> index fa44332..d7d9c4b 100644
> >> --- a/drivers/thunderbolt/nhi.c
> >> +++ b/drivers/thunderbolt/nhi.c
> >> @@ -1338,6 +1338,10 @@ static struct pci_device_id nhi_ids[] = {
> >> { PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_ADL_NHI1),
> >> .driver_data = (kernel_ulong_t)&icl_nhi_ops },
> >>
> >> + /* AMD USB4 host */
> >> + { PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_USB4_HIA0) },
> >> + { PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_USB4_HIA1) },
> >> +

I wonder if AMD USB4 controller exposes the USB4 PCI class ID? If that's
the case and you don't need any special quirking like Intel does then we
don't need to add any PCI IDs here and allow the below line to match.

This is actually what I hope we get eventually in Intel HW too.

> >> /* Any USB4 compliant host */
> >> { PCI_DEVICE_CLASS(PCI_CLASS_SERIAL_USB_USB4, ~0) },