From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Oliver Neukum <oneukum@suse.com>
Cc: USB list <linux-usb@vger.kernel.org>
Subject: Re: UCSI failing due to probe() getting version 0
Date: Wed, 11 Aug 2021 16:23:26 +0300 [thread overview]
Message-ID: <YRPPTjaFLy5t5HsP@kuha.fi.intel.com> (raw)
In-Reply-To: <db9e63df-80cc-6dae-89ae-23cb1cd09425@suse.com>
On Thu, Aug 05, 2021 at 04:04:03PM +0200, Oliver Neukum wrote:
> Hi,
>
> I am trying this on a new laptop, but I am getting a result I do not
> understand.
> ucsi_acpi_probe() is called, but ucsi_register() fails with -ENODEV,
> because ucsi->version is 0.
>
> If I dump the ucsi_acpi buffer I get:
>
> 00 00 00 00 02 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
>
> And, frankly I do not understand that. Why have the ACPI device
> but show version number 0?
Because of BIOS bugs.
Ideally we should be able to rely on the _STA method of the ACPI
device, but unfortunately with UCSI we can't rely on that alone. On
some systems the BIOS claims that the device is enabled (based on
_STA) even when the platform doesn't actually support UCSI at all.
If you remove the check, does the driver work?
Br,
--
heikki
next prev parent reply other threads:[~2021-08-11 13:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-05 14:04 UCSI failing due to probe() getting version 0 Oliver Neukum
2021-08-11 13:23 ` Heikki Krogerus [this message]
2021-08-11 14:47 ` Oliver Neukum
2021-08-12 8:10 ` Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRPPTjaFLy5t5HsP@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=linux-usb@vger.kernel.org \
--cc=oneukum@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).