From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jeaho Hwang <jhhwang@rtst.co.kr>
Cc: Peter Chen <peter.chen@kernel.org>, linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: chipidea: fix RT issue for udc
Date: Fri, 13 Aug 2021 09:08:34 +0200 [thread overview]
Message-ID: <YRYacrx5XH05+x+N@kroah.com> (raw)
In-Reply-To: <20210810060228.GA3326442@ubuntu>
On Tue, Aug 10, 2021 at 03:02:28PM +0900, Jeaho Hwang wrote:
> hw_ep_prime sometimes fails if irq occurs while it rus on RT kernel.
> to prevent local_irq_save should keep the function from irqs.
>
> I am not sure where is the best to submit this patch, between RT and USB
> community so sending to both. thanks.
>
> Signed-off-by: Jeaho Hwang <jhhwang@rtst.co.kr>
> ---
> drivers/usb/chipidea/udc.c | 31 +++++++++++++++++++++++++------
> 1 file changed, 25 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c
> index 5f35cdd2cf1d..a90498f17cc4 100644
> --- a/drivers/usb/chipidea/udc.c
> +++ b/drivers/usb/chipidea/udc.c
> @@ -102,6 +102,9 @@ static int hw_ep_flush(struct ci_hdrc *ci, int num, int dir)
> {
> int n = hw_ep_bit(num, dir);
>
> + /* From zynq-7000 TRM, It can take a long time
> + * so irq disable is not a good option for RT
> + */
Please use checkpatch.pl when submitting patches :(
next prev parent reply other threads:[~2021-08-13 7:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-10 6:02 [PATCH] usb: chipidea: fix RT issue for udc Jeaho Hwang
2021-08-13 7:08 ` Greg Kroah-Hartman [this message]
2021-08-16 0:52 ` Peter Chen
2021-08-16 1:03 ` Alan Stern
2021-08-16 3:52 ` Jeaho Hwang
2021-08-16 5:22 ` Greg Kroah-Hartman
2021-08-16 7:10 ` Jeaho Hwang
2021-08-16 7:16 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRYacrx5XH05+x+N@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jhhwang@rtst.co.kr \
--cc=linux-usb@vger.kernel.org \
--cc=peter.chen@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox