From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F024C4320A for ; Tue, 24 Aug 2021 13:55:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6133E61245 for ; Tue, 24 Aug 2021 13:55:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237461AbhHXN4b (ORCPT ); Tue, 24 Aug 2021 09:56:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:59904 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234695AbhHXN4a (ORCPT ); Tue, 24 Aug 2021 09:56:30 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id CD5EF610CD; Tue, 24 Aug 2021 13:55:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1629813346; bh=/ITeM5nvvoLZZjLEwLX57QOTvSNZpPpjCey2QzxIFR8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=h6I8HYm4yJrpUTDtyBeCbBe9E+sAFV6jkNQZEwBsi0GRDqcWgiVeGXQtiUIIp6PbB MlEmtLblZYHMUuPcBHGW6m0FFCLu+I0xBDcKgEwmVUK4jPpKeM8FBSY0Vc52eju0OU r6YOLJG7IKXiwTNx79l+B+Lc124p2veeCc6KlRxr+svDzxL/gaHe62GcsThRdERNVC 3MWpMkcddhsLcFS+7BOLbfrp+DJWW5kwR15TwuRxKL2v8/kAt2ZKGvLdS5lkC5iw5R pHruu9YJqxc6A1KoE3U3ESaazh7m9A3Q4tf9JYXuVG3eQQvXcJVl6mnItVBZqFhvbR o0JAXQcCMzdcg== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1mIWtx-0007Pv-VK; Tue, 24 Aug 2021 15:55:42 +0200 Date: Tue, 24 Aug 2021 15:55:41 +0200 From: Johan Hovold To: Utkarsh Verma Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Lukas Bulwahn Subject: Re: [PATCH] USB: serial: iuu_phoenix: Replace symbolic permissions by octal permissions Message-ID: References: <20210820190306.18149-1-utkarshverma294@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210820190306.18149-1-utkarshverma294@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Sat, Aug 21, 2021 at 12:33:06AM +0530, Utkarsh Verma wrote: > This fixed the below checkpatch issue: > WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. > Consider using octal permissions '0644'. Please do not run checkpatch.pl on code that's already in the tree. Use it for your own patches before submitting them and always use your own judgement when considering its suggestions. This code does not need to be changed. Johan