From: Greg KH <gregkh@linuxfoundation.org>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: balbi@kernel.org, linux-usb@vger.kernel.org,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH] usb: gadget: legacy: audio: add c_sync parameter
Date: Mon, 13 Sep 2021 07:52:15 +0200 [thread overview]
Message-ID: <YT7nD+ToVpe135LU@kroah.com> (raw)
In-Reply-To: <20210913024723.1334206-1-yoshihiro.shimoda.uh@renesas.com>
On Mon, Sep 13, 2021 at 11:47:23AM +0900, Yoshihiro Shimoda wrote:
> The commit 40c73b30546e ("usb: gadget: f_uac2: add adaptive sync
> support for capture") supported 'c_sync' for configfs file.
> To configure the 'c_sync' via legacy audio driver, add c_sync
> parameter. And then, we can change the 'c_sync' to 'ADAPTIVE' like
> below:
>
> modprobe g_audio c_sync=8
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> ---
> drivers/usb/gadget/legacy/audio.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/usb/gadget/legacy/audio.c b/drivers/usb/gadget/legacy/audio.c
> index a748ed0842e8..f9765bf63006 100644
> --- a/drivers/usb/gadget/legacy/audio.c
> +++ b/drivers/usb/gadget/legacy/audio.c
> @@ -49,6 +49,11 @@ MODULE_PARM_DESC(c_srate, "Capture Sampling Rate");
> static int c_ssize = UAC2_DEF_CSSIZE;
> module_param(c_ssize, uint, S_IRUGO);
> MODULE_PARM_DESC(c_ssize, "Capture Sample Size(bytes)");
> +
> +/* Capture Default ASYNC */
> +static int c_sync = UAC2_DEF_CSYNC;
> +module_param(c_sync, uint, S_IRUGO);
> +MODULE_PARM_DESC(c_sync, "Capture Sync Type");
Please do not add new module parameters when ever possible.
Why are you adding "new" features to the legacy driver? Why can you not
just use the newer driver instead if you want this feature?
thanks,
greg k-h
next prev parent reply other threads:[~2021-09-13 5:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-13 2:47 [PATCH] usb: gadget: legacy: audio: add c_sync parameter Yoshihiro Shimoda
2021-09-13 5:52 ` Greg KH [this message]
2021-09-13 7:12 ` Yoshihiro Shimoda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YT7nD+ToVpe135LU@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=balbi@kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox