From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8303EC432BE for ; Thu, 2 Sep 2021 08:42:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5E6D961059 for ; Thu, 2 Sep 2021 08:42:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244578AbhIBIn4 (ORCPT ); Thu, 2 Sep 2021 04:43:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:59666 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244570AbhIBIny (ORCPT ); Thu, 2 Sep 2021 04:43:54 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8834061059; Thu, 2 Sep 2021 08:42:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1630572175; bh=J8X65v6CDVr7gW2cb4AnafaJ9ERC5nOsmXg4IPqnt2g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=zJPlYJnbyGNUSP2by9zoJN+hLcCF6/ynSlkdwmLiQNE9FixTAjszk6lxBqODGo/DT wtUXWye6IyMPtorQqylz6Ppj7Rr2ZS+ZFD2a0hMCk6gsCsfHfAxZubV6CWI21HXG38 Y+8lpk8Nnu5kYDDga6Zx6iVuVjar/C+sHsXbIcDM= Date: Thu, 2 Sep 2021 10:42:52 +0200 From: Greg KH To: Faizel K B Cc: linux-usb@vger.kernel.org Subject: Re: [PATCH] usb: testusb: Fix for showing the connection speed Message-ID: References: <20210901181351.131378-1-faizel.kb@dicortech.com> <20210902083315.GA9371@faizel.kb> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210902083315.GA9371@faizel.kb> Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Thu, Sep 02, 2021 at 02:03:15PM +0530, Faizel K B wrote: > On Wed, Sep 01, 2021 at 08:24:08PM +0200, Greg KH wrote: > > On Wed, Sep 01, 2021 at 11:43:51PM +0530, Faizel K B wrote: > > > Signed-off-by: Faizel K B > > > --- > > > tools/usb/testusb.c | 14 ++++++++------ > > > 1 file changed, 8 insertions(+), 6 deletions(-) > > > > > > diff --git a/tools/usb/testusb.c b/tools/usb/testusb.c > > > index ee8208b2f946..69c3ead25313 100644 > > > --- a/tools/usb/testusb.c > > > +++ b/tools/usb/testusb.c > > > @@ -265,12 +265,6 @@ static int find_testdev(const char *name, const struct stat *sb, int flag) > > > } > > > > > > entry->ifnum = ifnum; > > > - > > > - /* FIXME update USBDEVFS_CONNECTINFO so it tells about high speed etc */ > > > - > > > - fprintf(stderr, "%s speed\t%s\t%u\n", > > > - speed(entry->speed), entry->name, entry->ifnum); > > > - > > > entry->next = testdevs; > > > testdevs = entry; > > > return 0; > > > @@ -299,6 +293,14 @@ static void *handle_testdev (void *arg) > > > return 0; > > > } > > > > > > + status = ioctl(fd, USBDEVFS_GET_SPEED, NULL); > > > + if (status < 0) > > > + fprintf(stderr, "USBDEVFS_GET_SPEED failed %d\n", status); > > > + else > > > + dev->speed = status; > > > + fprintf(stderr, "%s speed\t%s\t%u\n", > > > + speed(dev->speed), dev->name, dev->ifnum); > > > + > > > restart: > > > for (i = 0; i < TEST_CASES; i++) { > > > if (dev->test != -1 && dev->test != i) > > > -- > > > 2.25.1 > > > > > > > Hi, > > > > This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him > > a patch that has triggered this response. He used to manually respond > > to these common problems, but in order to save his sanity (he kept > > writing the same thing over and over, yet to different people), I was > > created. Hopefully you will not take offence and will fix the problem > > in your patch and resubmit it so that it can be accepted into the Linux > > kernel tree. > > > > You are receiving this message because of the following common error(s) > > as indicated below: > > > > - You did not specify a description of why the patch is needed, or > > possibly, any description at all, in the email body. Please read the > > section entitled "The canonical patch format" in the kernel file, > > Documentation/SubmittingPatches for what is needed in order to > > properly describe the change. > > > > - This looks like a new version of a previously submitted patch, but you > > did not list below the --- line any changes from the previous version. > > Please read the section entitled "The canonical patch format" in the > > kernel file, Documentation/SubmittingPatches for what needs to be done > > here to properly describe this. > > > > If you wish to discuss this problem further, or you have questions about > > how to resolve this issue, please feel free to respond to this email and > > Greg will reply once he has dug out from the pending patches received > > from other developers. > > > > thanks, > > > > greg k-h's patch email bot > Is it expected to be a separate patch (version 2)? Since the change is > only in the updated 'real name' for the 'from' field and 'Signed Off' field > in response with the previous message from the bot. Yes, of course, how else would we know this is a newer patch? thanks, greg k-h