public inbox for linux-usb@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Pavel Hofman <pavel.hofman@ivitera.com>
Cc: linux-usb@vger.kernel.org,
	Ruslan Bilovol <ruslan.bilovol@gmail.com>,
	Felipe Balbi <balbi@kernel.org>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Jack Pham <jackp@codeaurora.org>
Subject: Re: [PATCH] usb: gadget: f_uac2: fixed EP-IN wMaxPacketSize
Date: Fri, 24 Sep 2021 10:20:44 +0200	[thread overview]
Message-ID: <YU2KXJ/4Q2tq+ANv@kroah.com> (raw)
In-Reply-To: <20210924080027.5362-1-pavel.hofman@ivitera.com>

On Fri, Sep 24, 2021 at 10:00:27AM +0200, Pavel Hofman wrote:
> Async feedback patches broke enumeration on Windows 10 previously fixed
> by commit 789ea77310f0 ("usb: gadget: f_uac2: always increase endpoint
> max_packet_size by one audio slot").
> 
> While the existing calculation for EP OUT capture for async mode yields
> size+1 frame due to uac2_opts->fb_max > 0, playback side lost the +1
> feature.  Therefore the +1 frame addition must be re-introduced for
> playback. Win10 enumerates the device only when both EP IN and EP OUT
> max packet sizes are (at least) +1 frame.
> 
> Signed-off-by: Pavel Hofman <pavel.hofman@ivitera.com>
> Tested-by: Henrik Enquist <henrik.enquist@gmail.com>
> Tested-by: Jack Pham <jackp@codeaurora.org>
> ---
>  drivers/usb/gadget/function/f_uac2.c | 14 ++++++++++----
>  1 file changed, 10 insertions(+), 4 deletions(-)

What commit does this fix?

Should it go to stable kernel(s)?

thanks,

greg k-h

  reply	other threads:[~2021-09-24  8:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-24  8:00 [PATCH] usb: gadget: f_uac2: fixed EP-IN wMaxPacketSize Pavel Hofman
2021-09-24  8:20 ` Greg KH [this message]
2021-09-24  8:35   ` Pavel Hofman
2021-09-24 18:46     ` Jack Pham
2021-09-25  6:55       ` Pavel Hofman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YU2KXJ/4Q2tq+ANv@kroah.com \
    --to=greg@kroah.com \
    --cc=balbi@kernel.org \
    --cc=jackp@codeaurora.org \
    --cc=jbrunet@baylibre.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=pavel.hofman@ivitera.com \
    --cc=ruslan.bilovol@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox