Re: [PATCH] Update min() to min_t()

[Greg KH <gregkh@linuxfoundation.org>]

On Tue, Sep 21, 2021 at 07:52:46AM +0200, Philipp Hortmann wrote:
> This patch fixes the checkpatch.pl warning:
> WARNING: min() should probably be min_t(size_t, count, MAX_TRANSFER)
> +	size_t writesize = min(count, (size_t)MAX_TRANSFER);
> 
> Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
> ---
>  drivers/usb/usb-skeleton.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Please resend with the subject line adding the subsystem and driver name
so that we can better know what you are modifying here.

> diff --git a/drivers/usb/usb-skeleton.c b/drivers/usb/usb-skeleton.c
> index 2dc58766273a..d87deee3e26e 100644
> --- a/drivers/usb/usb-skeleton.c
> +++ b/drivers/usb/usb-skeleton.c
> @@ -363,7 +363,7 @@ static ssize_t skel_write(struct file *file, const char *user_buffer,
>  	int retval = 0;
>  	struct urb *urb = NULL;
>  	char *buf = NULL;
> -	size_t writesize = min(count, (size_t)MAX_TRANSFER);
> +	size_t writesize = min_t(size_t, count, MAX_TRANSFER);
>  
>  	dev = file->private_data;
>  
> -- 
> 2.25.1
> 

Has anyone actually built this driver in a while?

thanks,

greg k-h