* [PATCH] Update min() to min_t()
@ 2021-09-21 5:52 Philipp Hortmann
2021-09-21 6:04 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Philipp Hortmann @ 2021-09-21 5:52 UTC (permalink / raw)
To: gregkh, linux-usb, linux-kernel
This patch fixes the checkpatch.pl warning:
WARNING: min() should probably be min_t(size_t, count, MAX_TRANSFER)
+ size_t writesize = min(count, (size_t)MAX_TRANSFER);
Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
---
drivers/usb/usb-skeleton.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/usb-skeleton.c b/drivers/usb/usb-skeleton.c
index 2dc58766273a..d87deee3e26e 100644
--- a/drivers/usb/usb-skeleton.c
+++ b/drivers/usb/usb-skeleton.c
@@ -363,7 +363,7 @@ static ssize_t skel_write(struct file *file, const char *user_buffer,
int retval = 0;
struct urb *urb = NULL;
char *buf = NULL;
- size_t writesize = min(count, (size_t)MAX_TRANSFER);
+ size_t writesize = min_t(size_t, count, MAX_TRANSFER);
dev = file->private_data;
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Update min() to min_t()
2021-09-21 5:52 [PATCH] Update min() to min_t() Philipp Hortmann
@ 2021-09-21 6:04 ` Greg KH
2021-09-21 19:11 ` Philipp Hortmann
0 siblings, 1 reply; 4+ messages in thread
From: Greg KH @ 2021-09-21 6:04 UTC (permalink / raw)
To: Philipp Hortmann; +Cc: linux-usb, linux-kernel
On Tue, Sep 21, 2021 at 07:52:46AM +0200, Philipp Hortmann wrote:
> This patch fixes the checkpatch.pl warning:
> WARNING: min() should probably be min_t(size_t, count, MAX_TRANSFER)
> + size_t writesize = min(count, (size_t)MAX_TRANSFER);
>
> Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
> ---
> drivers/usb/usb-skeleton.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Please resend with the subject line adding the subsystem and driver name
so that we can better know what you are modifying here.
> diff --git a/drivers/usb/usb-skeleton.c b/drivers/usb/usb-skeleton.c
> index 2dc58766273a..d87deee3e26e 100644
> --- a/drivers/usb/usb-skeleton.c
> +++ b/drivers/usb/usb-skeleton.c
> @@ -363,7 +363,7 @@ static ssize_t skel_write(struct file *file, const char *user_buffer,
> int retval = 0;
> struct urb *urb = NULL;
> char *buf = NULL;
> - size_t writesize = min(count, (size_t)MAX_TRANSFER);
> + size_t writesize = min_t(size_t, count, MAX_TRANSFER);
>
> dev = file->private_data;
>
> --
> 2.25.1
>
Has anyone actually built this driver in a while?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Update min() to min_t()
2021-09-21 6:04 ` Greg KH
@ 2021-09-21 19:11 ` Philipp Hortmann
2021-09-22 5:58 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Philipp Hortmann @ 2021-09-21 19:11 UTC (permalink / raw)
To: Greg KH; +Cc: linux-usb, linux-kernel
On 9/21/21 8:04 AM, Greg KH wrote:
> On Tue, Sep 21, 2021 at 07:52:46AM +0200, Philipp Hortmann wrote:
>> diff --git a/drivers/usb/usb-skeleton.c b/drivers/usb/usb-skeleton.c
>> index 2dc58766273a..d87deee3e26e 100644
>> --- a/drivers/usb/usb-skeleton.c
>> +++ b/drivers/usb/usb-skeleton.c
>> @@ -363,7 +363,7 @@ static ssize_t skel_write(struct file *file, const char *user_buffer,
>> int retval = 0;
>> struct urb *urb = NULL;
>> char *buf = NULL;
>> - size_t writesize = min(count, (size_t)MAX_TRANSFER);
>> + size_t writesize = min_t(size_t, count, MAX_TRANSFER);
>>
>> dev = file->private_data;
>>
>> --
>> 2.25.1
>>
>
> Has anyone actually built this driver in a while?
>
> thanks,
>
> greg k-h
>
Hi,
I have build and loaded the driver. To me this seems OK.
dmesg from loading:
usb_skeleton: loading out-of-tree module taints kernel.
usb_skeleton: module verification failed: signature and/or required key
missing - tainting kernel
usbcore: registered new interface driver skeleton
dmesg from unloading:
usbcore: deregistering interface driver skeleton
Used kernel 5.15.0-rc1+
Bye Philipp
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Update min() to min_t()
2021-09-21 19:11 ` Philipp Hortmann
@ 2021-09-22 5:58 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2021-09-22 5:58 UTC (permalink / raw)
To: Philipp Hortmann; +Cc: linux-usb, linux-kernel
On Tue, Sep 21, 2021 at 09:11:25PM +0200, Philipp Hortmann wrote:
> On 9/21/21 8:04 AM, Greg KH wrote:
> > On Tue, Sep 21, 2021 at 07:52:46AM +0200, Philipp Hortmann wrote:
> > > diff --git a/drivers/usb/usb-skeleton.c b/drivers/usb/usb-skeleton.c
> > > index 2dc58766273a..d87deee3e26e 100644
> > > --- a/drivers/usb/usb-skeleton.c
> > > +++ b/drivers/usb/usb-skeleton.c
> > > @@ -363,7 +363,7 @@ static ssize_t skel_write(struct file *file, const char *user_buffer,
> > > int retval = 0;
> > > struct urb *urb = NULL;
> > > char *buf = NULL;
> > > - size_t writesize = min(count, (size_t)MAX_TRANSFER);
> > > + size_t writesize = min_t(size_t, count, MAX_TRANSFER);
> > > dev = file->private_data;
> > > --
> > > 2.25.1
> > >
> >
> > Has anyone actually built this driver in a while?
> >
> > thanks,
> >
> > greg k-h
> >
> Hi,
>
> I have build and loaded the driver. To me this seems OK.
>
> dmesg from loading:
> usb_skeleton: loading out-of-tree module taints kernel.
> usb_skeleton: module verification failed: signature and/or required key
> missing - tainting kernel
> usbcore: registered new interface driver skeleton
>
> dmesg from unloading:
> usbcore: deregistering interface driver skeleton
>
> Used kernel 5.15.0-rc1+
Great, can you resend a v2 of this with a fixed up subject line please?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-09-22 5:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-09-21 5:52 [PATCH] Update min() to min_t() Philipp Hortmann
2021-09-21 6:04 ` Greg KH
2021-09-21 19:11 ` Philipp Hortmann
2021-09-22 5:58 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox