From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76264C433EF for ; Tue, 21 Sep 2021 14:13:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5861F6115A for ; Tue, 21 Sep 2021 14:13:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233504AbhIUOOm (ORCPT ); Tue, 21 Sep 2021 10:14:42 -0400 Received: from mga01.intel.com ([192.55.52.88]:64086 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231781AbhIUOOg (ORCPT ); Tue, 21 Sep 2021 10:14:36 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10113"; a="245784326" X-IronPort-AV: E=Sophos;i="5.85,311,1624345200"; d="scan'208";a="245784326" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Sep 2021 06:47:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,311,1624345200"; d="scan'208";a="613011398" Received: from kuha.fi.intel.com ([10.237.72.162]) by fmsmga001.fm.intel.com with SMTP; 21 Sep 2021 06:46:55 -0700 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Tue, 21 Sep 2021 16:46:54 +0300 Date: Tue, 21 Sep 2021 16:46:54 +0300 From: Heikki Krogerus To: Sven Peter Cc: Greg Kroah-Hartman , Guido =?iso-8859-1?Q?G=FCnther?= , Bryan O'Donoghue , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Hector Martin , Mohamed Mediouni , Stan Skowronek , Mark Kettenis , Alexander Graf , Alyssa Rosenzweig Subject: Re: [RFT PATCH 8/9] usb: typec: tipd: Switch power state to S0 for Apple variant Message-ID: References: <20210918120934.28252-1-sven@svenpeter.dev> <20210918120934.28252-9-sven@svenpeter.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210918120934.28252-9-sven@svenpeter.dev> Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Sat, Sep 18, 2021 at 02:09:33PM +0200, Sven Peter wrote: > The Apple CD321x comes up in a low-power state after boot. Usually, the > bootloader will already power it up to S0 but let's do it here as well > in case that didn't happen. > > Suggested-by: Stan Skowronek > Signed-off-by: Sven Peter > --- > drivers/usb/typec/tipd/core.c | 44 +++++++++++++++++++++++++++++++ > drivers/usb/typec/tipd/tps6598x.h | 6 +++++ > 2 files changed, 50 insertions(+) > > diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c > index e96b17fe6af6..26807c050662 100644 > --- a/drivers/usb/typec/tipd/core.c > +++ b/drivers/usb/typec/tipd/core.c > @@ -30,6 +30,7 @@ > #define TPS_REG_INT_MASK2 0x17 > #define TPS_REG_INT_CLEAR1 0x18 > #define TPS_REG_INT_CLEAR2 0x19 > +#define TPS_REG_SYSTEM_POWER_STATE 0x20 > #define TPS_REG_STATUS 0x1a > #define TPS_REG_SYSTEM_CONF 0x28 > #define TPS_REG_CTRL_CONF 0x29 > @@ -84,6 +85,8 @@ struct tps6598x_hw { > unsigned int irq_data_status_update; > unsigned int irq_plug_event; > void (*irq_trace)(u64 event1, u64 event2); > + > + bool supports_spss; > }; > static const struct tps6598x_hw ti_tps6598x_data; > > @@ -161,6 +164,11 @@ static int tps6598x_block_write(struct tps6598x *tps, u8 reg, > return regmap_raw_write(tps->regmap, reg, data, sizeof(data)); > } > > +static inline int tps6598x_read8(struct tps6598x *tps, u8 reg, u8 *val) > +{ > + return tps6598x_block_read(tps, reg, val, sizeof(u8)); > +} > + > static inline int tps6598x_read16(struct tps6598x *tps, u8 reg, u16 *val) > { > return tps6598x_block_read(tps, reg, val, sizeof(u16)); > @@ -572,6 +580,35 @@ static int tps6598x_psy_get_prop(struct power_supply *psy, > return ret; > } > > +static int cd321x_switch_power_state(struct tps6598x *tps, u8 target_state) > +{ > + u8 state; > + int ret; > + > + if (!tps->hw->supports_spss) > + return 0; > + > + ret = tps6598x_read8(tps, TPS_REG_SYSTEM_POWER_STATE, &state); > + if (ret) > + return ret; > + > + if (state == target_state) > + return 0; > + > + ret = tps6598x_exec_cmd(tps, "SPSS", sizeof(u8), &target_state, 0, NULL); > + if (ret) > + return ret; > + > + ret = tps6598x_read8(tps, TPS_REG_SYSTEM_POWER_STATE, &state); > + if (ret) > + return ret; > + > + if (state != target_state) > + return -EINVAL; > + > + return 0; > +} > + > static int devm_tps6598_psy_register(struct tps6598x *tps) > { > struct power_supply_config psy_cfg = {}; > @@ -648,6 +685,11 @@ static int tps6598x_probe(struct i2c_client *client) > if (ret) > return ret; > > + /* Switch Apple chips to the correct system power state */ > + ret = cd321x_switch_power_state(tps, TPS_SYSTEM_POWER_STATE_S0); > + if (ret) > + return ret; If you call this from the same quirk where you set the mask for your board, you don't need that supports_spss flag at all, right? > ret = tps6598x_read32(tps, TPS_REG_STATUS, &status); > if (ret < 0) > return ret; > @@ -786,6 +828,7 @@ static const struct tps6598x_hw ti_tps6598x_data = { > .irq_data_status_update = TPS_REG_INT_DATA_STATUS_UPDATE, > .irq_plug_event = TPS_REG_INT_PLUG_EVENT, > .irq_trace = trace_tps6598x_irq, > + .supports_spss = false, > }; > > static const struct tps6598x_hw apple_cd321x_data = { > @@ -795,6 +838,7 @@ static const struct tps6598x_hw apple_cd321x_data = { > .irq_data_status_update = APPLE_TPS_REG_INT_DATA_STATUS_UPDATE, > .irq_plug_event = APPLE_TPS_REG_INT_PLUG_EVENT, > .irq_trace = trace_cd321x_irq, > + .supports_spss = true, > }; thanks, -- heikki