From: Johan Hovold <johan@kernel.org>
To: Yu-Tung Chang <mtwget@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: serial: option: add Quectel EC200S-CN module support
Date: Wed, 29 Sep 2021 09:48:26 +0200 [thread overview]
Message-ID: <YVQaSj+zIaoeZJKs@hovoldconsulting.com> (raw)
In-Reply-To: <20210929071713.319751-1-mtwget@gmail.com>
On Wed, Sep 29, 2021 at 03:17:13PM +0800, Yu-Tung Chang wrote:
> Add usb product id of the Quectel EC200S-CN module.
>
> usb-devices output for 0x6002:
> T: Bus=01 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 3 Spd=480 MxCh= 0
> D: Ver= 2.00 Cls=ef(misc ) Sub=02 Prot=01 MxPS=64 #Cfgs= 1
> P: Vendor=2c7c ProdID=6002 Rev=03.18
> S: Manufacturer=Android
> S: Product=Android
> S: SerialNumber=0000
> C: #Ifs= 5 Cfg#= 1 Atr=e0 MxPwr=500mA
> I: If#=0x0 Alt= 0 #EPs= 1 Cls=02(commc) Sub=06 Prot=00 Driver=cdc_ether
> I: If#=0x1 Alt= 1 #EPs= 2 Cls=0a(data ) Sub=00 Prot=00 Driver=cdc_ether
> I: If#=0x2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=(none)
> I: If#=0x3 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=(none)
> I: If#=0x4 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=(none)
>
> Signed-off-by: Yu-Tung Chang <mtwget@gmail.com>
> ---
> drivers/usb/serial/option.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> index 6cfb5d33609f..428d101f6193 100644
> --- a/drivers/usb/serial/option.c
> +++ b/drivers/usb/serial/option.c
> @@ -252,6 +252,7 @@ static void option_instat_callback(struct urb *urb);
> #define QUECTEL_PRODUCT_EM12 0x0512
> #define QUECTEL_PRODUCT_RM500Q 0x0800
> #define QUECTEL_PRODUCT_EC200T 0x6026
> +#define QUECTEL_PRODUCT_EC200S_CN 0x6002
You forgot the actual entry. Also keep the defines sorted by PID·
> #define CMOTECH_VENDOR_ID 0x16d8
> #define CMOTECH_PRODUCT_6001 0x6001
Johan
prev parent reply other threads:[~2021-09-29 7:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-29 7:17 [PATCH] USB: serial: option: add Quectel EC200S-CN module support Yu-Tung Chang
2021-09-29 7:48 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVQaSj+zIaoeZJKs@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mtwget@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox