From: Greg KH <gregkh@linuxfoundation.org>
To: Mathias Nyman <mathias.nyman@linux.intel.com>
Cc: linux-usb@vger.kernel.org,
Nehal Bakulchandra Shah <Nehal-Bakulchandra.shah@amd.com>,
Shyam Sundar S K <Shyam-sundar.S-k@amd.com>,
Mario Limonciello <mario.limonciello@amd.com>,
Basavaraj Natikar <Basavaraj.Natikar@amd.com>
Subject: Re: [PATCH 1/1] usb: xhci: Enable runtime-pm by default on AMD Yellow Carp platform
Date: Thu, 14 Oct 2021 14:27:18 +0200 [thread overview]
Message-ID: <YWgiJig8t2bRydxG@kroah.com> (raw)
In-Reply-To: <94f2ecef-94a8-6da5-95a6-ed12f6820b54@linux.intel.com>
On Thu, Oct 14, 2021 at 03:03:22PM +0300, Mathias Nyman wrote:
> On 13.10.2021 19.42, Greg KH wrote:
> > On Wed, Oct 13, 2021 at 06:16:33PM +0300, Mathias Nyman wrote:
> >> From: Nehal Bakulchandra Shah <Nehal-Bakulchandra.shah@amd.com>
> >>
> >> AMD's Yellow Carp platform supports runtime power management for
> >> XHCI Controllers, so enable the same by default for all XHCI Controllers.
> >>
> >> Signed-off-by: Nehal Bakulchandra Shah <Nehal-Bakulchandra.shah@amd.com>
> >> Reviewed-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
> >> Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
> >> Reviewed-by: Basavaraj Natikar <Basavaraj.Natikar@amd.com>
> >> Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
> >> ---
> >> drivers/usb/host/xhci-pci.c | 15 +++++++++++++++
> >> 1 file changed, 15 insertions(+)
> >>
> >> diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
> >> index 2c9f25ca8edd..0e571d6af2ab 100644
> >> --- a/drivers/usb/host/xhci-pci.c
> >> +++ b/drivers/usb/host/xhci-pci.c
> >> @@ -69,6 +69,12 @@
> >> #define PCI_DEVICE_ID_ASMEDIA_1142_XHCI 0x1242
> >> #define PCI_DEVICE_ID_ASMEDIA_2142_XHCI 0x2142
> >> #define PCI_DEVICE_ID_ASMEDIA_3242_XHCI 0x3242
> >> +#define PCI_DEVICE_ID_AMD_YELLOW_CARP_XHCI_1 0x161a
> >> +#define PCI_DEVICE_ID_AMD_YELLOW_CARP_XHCI_2 0x161b
> >> +#define PCI_DEVICE_ID_AMD_YELLOW_CARP_XHCI_3 0x161d
> >> +#define PCI_DEVICE_ID_AMD_YELLOW_CARP_XHCI_4 0x161e
> >> +#define PCI_DEVICE_ID_AMD_YELLOW_CARP_XHCI_5 0x15d6
> >> +#define PCI_DEVICE_ID_AMD_YELLOW_CARP_XHCI_6 0x15d7
> >
> > Please keep the ids aligned whenever possible. Why is there not 2 tabs
> > being used here?
>
> I'll fix that and resend
The original author should have fixed that up, but you are being nice :)
prev parent reply other threads:[~2021-10-14 12:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-13 15:16 [PATCH 0/1] xhci feature for usb-next Mathias Nyman
2021-10-13 15:16 ` [PATCH 1/1] usb: xhci: Enable runtime-pm by default on AMD Yellow Carp platform Mathias Nyman
2021-10-13 16:42 ` Greg KH
2021-10-14 12:03 ` Mathias Nyman
2021-10-14 12:27 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YWgiJig8t2bRydxG@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Basavaraj.Natikar@amd.com \
--cc=Nehal-Bakulchandra.shah@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=linux-usb@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=mathias.nyman@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox