From: Greg KH <gregkh@linuxfoundation.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
linux-aio@kvack.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH v2] fs: replace the ki_complete two integer arguments with a single argument
Date: Thu, 21 Oct 2021 10:06:48 +0200 [thread overview]
Message-ID: <YXEfmG4l5Y3WxeUp@kroah.com> (raw)
In-Reply-To: <4d409f23-2235-9fa6-4028-4d6c8ed749f8@kernel.dk>
On Wed, Oct 20, 2021 at 01:08:17PM -0600, Jens Axboe wrote:
> The second argument is only used by the USB gadget code, yet everyone
> pays the overhead of passing a zero to be passed into aio, where it
> ends up being part of the aio res2 value.
>
> Since we pass this value around as long, there's only 32-bits of
> information in each of these. Linux IO transfers are capped at INT_MAX
> anyway, so could not be any larger return value. For the one cases where
> we care about this second result, mask it into the upper bits of the
> value passed in. aio can then simply shift to get it.
>
> For everyone else, just pass in res as an argument like before. Update
> all ki_complete handlers to conform to the new prototype.
>
> On 64-bit, this avoids an extra register allocation and clear for the
> the fast path (non-USB gadget...).
>
> Signed-off-by: Jens Axboe <axboe@kernel.dk>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
next prev parent reply other threads:[~2021-10-21 8:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-20 19:08 [PATCH v2] fs: replace the ki_complete two integer arguments with a single argument Jens Axboe
2021-10-21 8:06 ` Greg KH [this message]
2021-10-21 8:32 ` Christoph Hellwig
2021-10-21 10:57 ` Christoph Hellwig
2021-10-21 14:34 ` Jens Axboe
2021-10-21 14:42 ` Christoph Hellwig
2021-10-21 14:44 ` Jens Axboe
2021-10-21 14:47 ` Christoph Hellwig
2021-10-21 15:18 ` Jeff Moyer
2021-10-21 15:19 ` Jens Axboe
2021-10-21 18:05 ` Jeff Moyer
2021-10-21 20:41 ` Jens Axboe
2021-10-21 20:58 ` Jeff Moyer
2021-10-21 21:03 ` Jeff Moyer
2021-10-22 14:19 ` Jens Axboe
2021-10-22 15:29 ` Jens Axboe
2021-10-22 15:47 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXEfmG4l5Y3WxeUp@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=axboe@kernel.dk \
--cc=linux-aio@kvack.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox