public inbox for linux-usb@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	corbet@lwn.net, linux-doc@vger.kernel.org
Subject: Re: [PATCH] usb: usb-skeleton: Add hint to find __init and __exit
Date: Sat, 23 Oct 2021 08:47:31 +0200	[thread overview]
Message-ID: <YXOwA6N2ffVIcA7L@kroah.com> (raw)
In-Reply-To: <20211023052538.GA5141@matrix-ESPRIMO-P710>

On Sat, Oct 23, 2021 at 07:25:38AM +0200, Philipp Hortmann wrote:
> Comment to find __init and __exit.
> 
> Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
> ---
>  drivers/usb/usb-skeleton.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/usb-skeleton.c b/drivers/usb/usb-skeleton.c
> index 2dc58766273a..80338a50dcde 100644
> --- a/drivers/usb/usb-skeleton.c
> +++ b/drivers/usb/usb-skeleton.c
> @@ -641,6 +641,7 @@ static struct usb_driver skel_driver = {
>  	.supports_autosuspend = 1,
>  };
>  
> +/* __init and __exit */
>  module_usb_driver(skel_driver);

This comment makes no sense, sorry.  __init and __exit are things that
the linker uses, why would you need to "find" them?

thanks,

greg k-h

  reply	other threads:[~2021-10-23  6:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-23  5:25 [PATCH] usb: usb-skeleton: Add hint to find __init and __exit Philipp Hortmann
2021-10-23  6:47 ` Greg KH [this message]
2021-10-23  7:11   ` Philipp Hortmann
2021-10-23  8:50     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YXOwA6N2ffVIcA7L@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=corbet@lwn.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=philipp.g.hortmann@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox