Re: [PATCH] usb: remove res2 argument from gadget code completions

Greg Kroah-Hartman
2021-10-25T15:25:53Z

On Mon, Oct 25, 2021 at 09:23:58AM -0600, Jens Axboe wrote:
> The USB gadget code is the only code that every tried to utilize the
> 2nd argument of the aio completions, but there are strong suspicions
> that it was never actually used by anything on the userspace side.
>
> Out of the 3 cases that touch it, two of them just pass in the same
> as res, and the last one passes in error/transfer in res like any
> other normal use case.
>
> Remove the 2nd argument, pass 0 like the rest of the in-kernel users
> of kiocb based IO.
>
> Link: https://lore.kernel.org/linux-block/20211021174021.273c82b1.john@metanate.com/
> Signed-off-by: Jens Axboe <axboe@kernel.dk>
>
> ---
>
> Greg/John - if you guys are fine with this patch, let me know. I've got
> the ->ki_complete() argument removal sitting on top of this.

Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>