From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: linux@roeck-us.net, gregkh@linuxfoundation.org,
bjorn.andersson@linaro.org, robh+dt@kernel.org,
linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org,
wcheng@codeaurora.org
Subject: Re: [PATCH 6/6] usb: typec: qcom: Add pm8150b TCPM driver
Date: Tue, 26 Oct 2021 10:46:55 +0300 [thread overview]
Message-ID: <YXeyb76jh4bim3lS@kuha.fi.intel.com> (raw)
In-Reply-To: <20211025150906.176686-7-bryan.odonoghue@linaro.org>
On Mon, Oct 25, 2021 at 04:09:06PM +0100, Bryan O'Donoghue wrote:
> The PM8150b contains both a type-c controller and a power-delivery PHY.
> This driver binds both of those blocks together via a virtual TCPM driver.
>
> qcom-pmic-tcpm.c is responsible for registering with tcpm and wrappers
> calls into the type-c and pdphy drivers from tcpm.
> Its up to qcom-pmic-tcpm.c to wait for both
> qcom-pmic-pdphy.c and qcom-pmic-typec.c to probe before
> registering a type-c port
>
> qcom-pmic-pdphy.c implements a set functions that qcom-pmic-tcpm.c is
> responsible for interfacing with the pdphy hardware and
> processing power-delivery related calls from tcpm.
>
> qcom-pmic-typec.c implements a similar interface for the typec hardware
> interface and is responsible for notifying and processing
> type-c related calls from tcpm.
>
> In conjunction with appropriate entries in the platform dts we can
> establish a source or sink contract with a PD peer and indeed negotiate SBU
> alternative modes.
>
> This code provides all of the same functionality as the existing
> qcom typec driver plus power-delivery as well.
>
> As a result commit 6c8cf3695176 ("usb: typec: Add QCOM PMIC typec detection
> driver") can be deleted entirely.
>
> References code from Jonathan Marek, Jack Pham, Wesley Cheng, Hemant Kumar,
> Guru Das Srinagesh and Ashay Jaiswal.
>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
> MAINTAINERS | 8 +
> drivers/usb/typec/Makefile | 1 -
> drivers/usb/typec/qcom-pmic-typec.c | 262 --------
You removed the file and the Makefile entry, but you left the Kconfig
entry? Please remove that too.
> drivers/usb/typec/tcpm/Kconfig | 11 +
> drivers/usb/typec/tcpm/Makefile | 1 +
> .../usb/typec/tcpm/qcom/qcom_pmic_tcpm_core.c | 345 ++++++++++
> .../typec/tcpm/qcom/qcom_pmic_tcpm_pdphy.c | 577 +++++++++++++++++
> .../typec/tcpm/qcom/qcom_pmic_tcpm_pdphy.h | 85 +++
> .../typec/tcpm/qcom/qcom_pmic_tcpm_typec.c | 593 ++++++++++++++++++
> .../typec/tcpm/qcom/qcom_pmic_tcpm_typec.h | 163 +++++
> 10 files changed, 1783 insertions(+), 263 deletions(-)
> delete mode 100644 drivers/usb/typec/qcom-pmic-typec.c
> create mode 100644 drivers/usb/typec/tcpm/qcom/qcom_pmic_tcpm_core.c
> create mode 100644 drivers/usb/typec/tcpm/qcom/qcom_pmic_tcpm_pdphy.c
> create mode 100644 drivers/usb/typec/tcpm/qcom/qcom_pmic_tcpm_pdphy.h
> create mode 100644 drivers/usb/typec/tcpm/qcom/qcom_pmic_tcpm_typec.c
> create mode 100644 drivers/usb/typec/tcpm/qcom/qcom_pmic_tcpm_typec.h
You don't have a Makefile in that new directory typec/tcpm/qcom?
How do you compile these new drivers?
thanks,
--
heikki
next prev parent reply other threads:[~2021-10-26 7:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-25 15:09 [PATCH 0/6] Add pm8150b TPCM driver Bryan O'Donoghue
2021-10-25 15:09 ` [PATCH 1/6] dt-bindings: usb: Add qcom,pmic-usb-typec dt-binding header Bryan O'Donoghue
2021-10-25 15:09 ` [PATCH 2/6] dt-bindings: usb: Add Qualcomm PMIC type C controller YAML schema Bryan O'Donoghue
2021-10-25 15:09 ` [PATCH 3/6] dt-bindings: usb: Add qcom,pmic-usb-pdphy dt-binding header Bryan O'Donoghue
2021-10-25 15:09 ` [PATCH 4/6] dt-bindings: usb: Add Qualcomm PMIC PDPHY controller YAML schema Bryan O'Donoghue
2021-10-25 15:09 ` [PATCH 5/6] dt-bindings: usb: Add Qualcomm PMIC TCPM " Bryan O'Donoghue
2021-10-25 15:09 ` [PATCH 6/6] usb: typec: qcom: Add pm8150b TCPM driver Bryan O'Donoghue
2021-10-25 16:17 ` Guenter Roeck
2021-10-25 16:39 ` Bryan O'Donoghue
2021-10-25 20:57 ` Bryan O'Donoghue
2021-10-25 20:21 ` Randy Dunlap
2021-10-26 7:46 ` Heikki Krogerus [this message]
2021-10-26 7:55 ` Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXeyb76jh4bim3lS@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=bjorn.andersson@linaro.org \
--cc=bryan.odonoghue@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
--cc=wcheng@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox