From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: "Francisco Blas Izquierdo Riera (klondike)" <klondike@klondike.es>
Cc: linux-usb@vger.kernel.org,
Andreas Noever <andreas.noever@gmail.com>,
Michael Jamet <michael.jamet@intel.com>,
Yehezkel Bernat <YehezkelShB@gmail.com>,
Kranthi Kuntala <kranthi.kuntala@intel.com>,
Rajmohan Mani <rajmohan.mani@intel.com>,
Mario.Limonciello@dell.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Lukas Wunner <lukas@wunner.de>, Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org
Subject: Re: [PATCH 1/2] thunderbolt: allow vendor ID override for NVM programming
Date: Thu, 25 Nov 2021 08:16:55 +0200 [thread overview]
Message-ID: <YZ8qVwt9k6Y8cSq+@lahna> (raw)
In-Reply-To: <07bd1d90-c95f-0685-e1a8-2211c9dac251@klondike.es>
Hi,
On Wed, Nov 24, 2021 at 05:37:05PM +0100, Francisco Blas Izquierdo Riera (klondike) wrote:
> Currently, the vendor ID reported by the chipset is checked before to
> avoid accidentally programming devices from unsupported vendors with
> a different NVM structure.
>
> Certain Thunderbolt devices store the vendor ID in the NVM, therefore
> if the NVM has become corrrupted the device will report an invalid
> vendor ID and reflashing will be impossible on GNU/Linux even if the
> device can boot in safe mode.
How this can happen? The NVM upgrade verifies the signature of the new
NVM and does not allow upgrade if it does not match. Only way I can see
this happens is that the NVM is flashed directly to the flash chip
through some external tool like dediprog, or the NVM was corrupted
before it was signed at Intel which should not happen either (but OK,
mistakes can happen).
Can you give some more details about the issue? Which device it is and
how did the NVM ended being invalid?
next prev parent reply other threads:[~2021-11-25 6:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-24 16:34 [PATCH 0/2] Thunderbolt: allow vendor ID override for NVM programming Francisco Blas Izquierdo Riera (klondike)
2021-11-24 16:37 ` [PATCH 1/2] thunderbolt: " Francisco Blas Izquierdo Riera (klondike)
2021-11-24 18:26 ` Greg Kroah-Hartman
2021-11-24 18:32 ` klondike
2021-11-24 18:37 ` Greg Kroah-Hartman
2021-11-24 18:56 ` klondike
2021-11-25 6:02 ` Greg Kroah-Hartman
2021-11-25 6:16 ` Mika Westerberg [this message]
2021-11-24 16:37 ` [PATCH 2/2] Documentation: explain how to override Thunderbolt Vendor ID Francisco Blas Izquierdo Riera (klondike)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZ8qVwt9k6Y8cSq+@lahna \
--to=mika.westerberg@linux.intel.com \
--cc=Mario.Limonciello@dell.com \
--cc=YehezkelShB@gmail.com \
--cc=andreas.noever@gmail.com \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=klondike@klondike.es \
--cc=kranthi.kuntala@intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=michael.jamet@intel.com \
--cc=rajmohan.mani@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox