From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Gil Fine <gil.fine@intel.com>
Cc: andreas.noever@gmail.com, michael.jamet@intel.com,
YehezkelShB@gmail.com, linux-usb@vger.kernel.org,
lukas@wunner.de
Subject: Re: [PATCH 6/7] thunderbolt: Enable CLx for Titan Ridge device
Date: Mon, 29 Nov 2021 10:28:25 +0200 [thread overview]
Message-ID: <YaSPKZzif4Dx1ctC@lahna> (raw)
In-Reply-To: <20211125143821.16558-7-gil.fine@intel.com>
Hi,
On Thu, Nov 25, 2021 at 04:38:20PM +0200, Gil Fine wrote:
> diff --git a/drivers/thunderbolt/tb_regs.h b/drivers/thunderbolt/tb_regs.h
> index 08f1213ea565..4786e15241c8 100644
> --- a/drivers/thunderbolt/tb_regs.h
> +++ b/drivers/thunderbolt/tb_regs.h
> @@ -307,6 +307,10 @@ struct tb_regs_port_header {
> #define TMU_ADP_CS_3_UDM BIT(29)
> #define TMU_ADP_CS_6 0x06
> #define TMU_ADP_CS_6_DTS BIT(1)
> +/* Used for Titan Ridge only */
> +#define TMU_ADP_CS_6_DISABLE_TMU_OBJ_MASK GENMASK(3, 2)
> +#define TMU_ADP_CS_6_DISABLE_TMU_OBJ_CL1 BIT(2)
> +#define TMU_ADP_CS_6_DISABLE_TMU_OBJ_CL2 BIT(3)
I think these should be part of the Thunderbolt (legacy) specific
registers as below (these are not in the USB4 spec).
>
> /* Lane adapter registers */
> #define LANE_ADP_CS_0 0x00
> @@ -447,8 +451,33 @@ struct tb_regs_hop {
> } __packed;
>
> /* TMU Thunderbolt 3 registers */
> -#define TB_TIME_VSEC_3_CS_26 0x1a
> -#define TB_TIME_VSEC_3_CS_26_TD BIT(22)
> +#define TB_TIME_VSEC_3_CS_9 0x9
> +#define TB_TIME_VSEC_3_CS_9_TMU_OBJ_MASK GENMASK(17, 16)
> +#define TB_TIME_VSEC_3_CS_26 0x1a
> +#define TB_TIME_VSEC_3_CS_26_TD BIT(22)
next prev parent reply other threads:[~2021-11-29 8:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-25 14:38 [PATCH 0/7] thunderbolt: CLx support for USB4 and Titan Ridge Gil Fine
2021-11-25 14:38 ` [PATCH 1/7] thunderbolt: Add TMU unidirectional mode Gil Fine
2021-11-26 11:58 ` Yehezkel Bernat
2021-11-29 8:19 ` Mika Westerberg
2021-11-25 14:38 ` [PATCH 2/7] thunderbolt: Add CL0s support for USB4 Gil Fine
2021-11-29 8:38 ` Mika Westerberg
2021-11-25 14:38 ` [PATCH 3/7] thunderbolt: Move usb4_switch_wait_for_bit() to switch.c Gil Fine
2021-11-25 14:38 ` [PATCH 4/7] thunderbolt: Enable TMU for Titan Ridge device Gil Fine
2021-11-25 14:38 ` [PATCH 5/7] thunderbolt: Rename Intel VSC capability Gil Fine
2021-11-25 14:38 ` [PATCH 6/7] thunderbolt: Enable CLx for Titan Ridge device Gil Fine
2021-11-29 8:28 ` Mika Westerberg [this message]
2021-11-25 14:38 ` [PATCH 7/7] thunderbolt: Add kernel param for CLx disabling Gil Fine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YaSPKZzif4Dx1ctC@lahna \
--to=mika.westerberg@linux.intel.com \
--cc=YehezkelShB@gmail.com \
--cc=andreas.noever@gmail.com \
--cc=gil.fine@intel.com \
--cc=linux-usb@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=michael.jamet@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).