[PATCH] usb: typec: clear usb_pd flag if change to typec only mode

[PATCH] usb: typec: clear usb_pd flag if change to typec only mode

[steven_syu]

This patch handle power mode change from PD to Type-C only
and the user space unknown power delivery  was turned off
by typec driver.

Signed-off-by: steven_syu <steven_syu@asus.com>
---
 drivers/usb/typec/class.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c
index aeef453..11e2a98 100644
--- a/drivers/usb/typec/class.c
+++ b/drivers/usb/typec/class.c
@@ -1718,6 +1718,10 @@ void typec_set_pwr_opmode(struct typec_port *port,
                        partner->usb_pd = 1;
                        sysfs_notify(&partner_dev->kobj, NULL,
                                     "supports_usb_power_delivery");
+               } else if (opmode != TYPEC_PWR_MODE_PD && partner->usb_pd) {
+                       partner->usb_pd = 0;
+                       sysfs_notify(&partner_dev->kobj, NULL,
+                                    "supports_usb_power_delivery");
                }
                put_device(partner_dev);
        }
--
2.7.4

===================================================================================================================================
¾÷±K¸ê°T This email and any attachments to it contain confidential information and are intended solely for the use of the individual to whom it is addressed.If you are not the intended recipient or receive it accidentally, please immediately notify the sender by e-mail and delete the message and any attachments from your computer system, and destroy all hard copies. If any, please be advised that any unauthorized disclosure, copying, distribution or any action taken or omitted in reliance on this, is illegal and prohibited. Furthermore, any views or opinions expressed are solely those of the author and do not represent those of ASUSTeK. Thank you for your cooperation.
===================================================================================================================================

Re: [PATCH] usb: typec: clear usb_pd flag if change to typec only mode

[Greg KH]

On Tue, Nov 30, 2021 at 10:57:13AM +0800, steven_syu wrote:
> This patch handle power mode change from PD to Type-C only
> and the user space unknown power delivery  was turned off
> by typec driver.

I do not understand this sentance, can you please rewrite it a bit?

> Signed-off-by: steven_syu <steven_syu@asus.com>

Please use the name you sign documents with, I doubt you do so with a
"_" in it, right?

> ---
>  drivers/usb/typec/class.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c
> index aeef453..11e2a98 100644
> --- a/drivers/usb/typec/class.c
> +++ b/drivers/usb/typec/class.c
> @@ -1718,6 +1718,10 @@ void typec_set_pwr_opmode(struct typec_port *port,
>                         partner->usb_pd = 1;
>                         sysfs_notify(&partner_dev->kobj, NULL,
>                                      "supports_usb_power_delivery");
> +               } else if (opmode != TYPEC_PWR_MODE_PD && partner->usb_pd) {
> +                       partner->usb_pd = 0;
> +                       sysfs_notify(&partner_dev->kobj, NULL,
> +                                    "supports_usb_power_delivery");

Are you sure this is correct?  You set usb_pd to 0 and then told
userspace it was 1?

confused,

greg k-h

Re: [PATCH] usb: typec: clear usb_pd flag if change to typec only mode

[Heikki Krogerus]

On Tue, Nov 30, 2021 at 10:57:13AM +0800, steven_syu wrote:
> This patch handle power mode change from PD to Type-C only
> and the user space unknown power delivery  was turned off
> by typec driver.
> 
> Signed-off-by: steven_syu <steven_syu@asus.com>
> ---
>  drivers/usb/typec/class.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c
> index aeef453..11e2a98 100644
> --- a/drivers/usb/typec/class.c
> +++ b/drivers/usb/typec/class.c
> @@ -1718,6 +1718,10 @@ void typec_set_pwr_opmode(struct typec_port *port,
>                         partner->usb_pd = 1;
>                         sysfs_notify(&partner_dev->kobj, NULL,
>                                      "supports_usb_power_delivery");
> +               } else if (opmode != TYPEC_PWR_MODE_PD && partner->usb_pd) {
> +                       partner->usb_pd = 0;
> +                       sysfs_notify(&partner_dev->kobj, NULL,
> +                                    "supports_usb_power_delivery");
>                 }
>                 put_device(partner_dev);
>         }
> --
> 2.7.4
> 
> ===================================================================================================================================
> ???K???T This email and any attachments to it contain confidential information and are intended solely for the use of the individual to whom it is addressed.If you are not the intended recipient or receive it accidentally, please immediately notify the sender by e-mail and delete the message and any attachments from your computer system, and destroy all hard copies. If any, please be advised that any unauthorized disclosure, copying, distribution or any action taken or omitted in reliance on this, is illegal and prohibited. Furthermore, any views or opinions expressed are solely those of the author and do not represent those of ASUSTeK. Thank you for your cooperation.
> ===================================================================================================================================

Please remove that footer from the next mail.

thanks,

-- 
heikki