Re: [PATCH bpf v2] treewide: add missing includes masked by cgroup -> bpf dependency

Alexei Starovoitov
2021-12-03T19:09:27Z

On Thu, Dec 2, 2021 at 11:11 PM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Thu, Dec 02, 2021 at 12:34:00PM -0800, Jakub Kicinski wrote:
> > cgroup.h (therefore swap.h, therefore half of the universe)
> > includes bpf.h which in turn includes module.h and slab.h.
> > Since we're about to get rid of that dependency we need
> > to clean things up.
> >
> > v2: drop the cpu.h include from cacheinfo.h, it's not necessary
> > and it makes riscv sensitive to ordering of include files.
> >
> > Link: https://lore.kernel.org/all/20211120035253.72074-1-kuba@kernel.org/ # v1
> > Link: https://lore.kernel.org/all/20211120165528.197359-1-kuba@kernel.org/ # cacheinfo discussion
> > Acked-by: Krzysztof Wilczyński <kw@linux.com>
> > Acked-by: Peter Chen <peter.chen@kernel.org>
> > Acked-by: SeongJae Park <sj@kernel.org>
> > Acked-by: Jani Nikula <jani.nikula@intel.com>
> > Signed-off-by: Jakub Kicinski <kuba@kernel.org>
>
> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

I'm not sure how to test that it helps to reduce build deps,
but it builds and passes tests, so applied to bpf tree.
Jakub, you'll soon get it back via bpf tree PR :)