From: Greg KH <gregkh@linuxfoundation.org>
To: Julio Faracco <jcfaracco@gmail.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
stern@rowland.harvard.edu, axboe@kernel.dk, tglx@linutronix.de,
damien.lemoal@wdc.com, dkadashev@gmail.com,
paul.gortmaker@windriver.com, zhouyanjie@wanyeetech.com,
niklas.cassel@wdc.com, penguin-kernel@i-love.sakura.ne.jp,
macro@orcam.me.uk, caihuoqing@baidu.com
Subject: Re: [PATCH] usb: fixing some clang warnings inside usb host drivers
Date: Sat, 18 Dec 2021 10:13:29 +0100 [thread overview]
Message-ID: <Yb2mOUHSwE+iUrkm@kroah.com> (raw)
In-Reply-To: <20211218042420.28466-1-jcfaracco@gmail.com>
On Sat, Dec 18, 2021 at 01:24:20AM -0300, Julio Faracco wrote:
> Clang is reporting some issues related variable values not used and
> other issues inside some USB host drivers. This commit removes some
> trashes and adds some strategies to mitigate those warnings.
>
> The most important is the maxpacket not checking for zeros inside both
> functions qtd_fill(). Even if this variable is always higher than zero,
> it should be checked to avoid this kind of verbosity.
>
> Signed-off-by: Julio Faracco <jcfaracco@gmail.com>
Please break this up into "one patch per warning" and show the warning
that is happening as well, as it is not obvious why you are changing
these files in the way you are doing it.
thanks,
greg k-h
next prev parent reply other threads:[~2021-12-18 9:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-18 4:24 [PATCH] usb: fixing some clang warnings inside usb host drivers Julio Faracco
2021-12-18 9:13 ` Greg KH [this message]
2021-12-18 10:49 ` Joe Perches
2021-12-18 18:05 ` Alan Stern
2021-12-19 1:41 ` Tetsuo Handa
2021-12-19 2:50 ` Alan Stern
2021-12-19 7:59 ` Tetsuo Handa
2021-12-19 15:46 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yb2mOUHSwE+iUrkm@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=axboe@kernel.dk \
--cc=caihuoqing@baidu.com \
--cc=damien.lemoal@wdc.com \
--cc=dkadashev@gmail.com \
--cc=jcfaracco@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=macro@orcam.me.uk \
--cc=niklas.cassel@wdc.com \
--cc=paul.gortmaker@windriver.com \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=stern@rowland.harvard.edu \
--cc=tglx@linutronix.de \
--cc=zhouyanjie@wanyeetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox