From: Alan Stern <stern@rowland.harvard.edu>
To: Pavel Hofman <pavel.hofman@ivitera.com>
Cc: linux-usb@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 2/2] usb: core: config: using bit mask instead of individual bits
Date: Fri, 10 Dec 2021 10:48:42 -0500 [thread overview]
Message-ID: <YbN22jGdvTkWS1O3@rowland.harvard.edu> (raw)
In-Reply-To: <20211210085219.16796-2-pavel.hofman@ivitera.com>
On Fri, Dec 10, 2021 at 09:52:19AM +0100, Pavel Hofman wrote:
> Using standard USB_EP_MAXP_MULT_MASK instead of individual bits for
> extracting multiple-transactions bits from wMaxPacketSize value.
>
> Signed-off-by: Pavel Hofman <pavel.hofman@ivitera.com>
> ---
Acked-by: Alan Stern <stern@rowland.harvard.edu>
> drivers/usb/core/config.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/core/config.c b/drivers/usb/core/config.c
> index 74eb356c8767..00e28456e4cc 100644
> --- a/drivers/usb/core/config.c
> +++ b/drivers/usb/core/config.c
> @@ -422,9 +422,9 @@ static int usb_parse_endpoint(struct device *ddev, int cfgno,
> maxpacket_maxes = full_speed_maxpacket_maxes;
> break;
> case USB_SPEED_HIGH:
> - /* Bits 12..11 are allowed only for HS periodic endpoints */
> + /* Multiple-transactions bits are allowed only for HS periodic endpoints */
> if (usb_endpoint_xfer_int(d) || usb_endpoint_xfer_isoc(d)) {
> - i = maxp & (BIT(12) | BIT(11));
> + i = maxp & USB_EP_MAXP_MULT_MASK;
> maxp &= ~i;
> }
> fallthrough;
> --
> 2.25.1
>
next prev parent reply other threads:[~2021-12-10 15:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-10 8:52 [PATCH 1/2] usb: core: config: fix validation of wMaxPacketValue entries Pavel Hofman
2021-12-10 8:52 ` [PATCH 2/2] usb: core: config: using bit mask instead of individual bits Pavel Hofman
2021-12-10 15:48 ` Alan Stern [this message]
2021-12-10 15:48 ` [PATCH 1/2] usb: core: config: fix validation of wMaxPacketValue entries Alan Stern
2021-12-10 15:53 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbN22jGdvTkWS1O3@rowland.harvard.edu \
--to=stern@rowland.harvard.edu \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=pavel.hofman@ivitera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox