From: Alan Stern <stern@rowland.harvard.edu>
To: Pavel Hofman <pavel.hofman@ivitera.com>
Cc: linux-usb@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 1/2] usb: core: config: fix validation of wMaxPacketValue entries
Date: Fri, 10 Dec 2021 10:48:21 -0500 [thread overview]
Message-ID: <YbN2xd7DJuULtOUI@rowland.harvard.edu> (raw)
In-Reply-To: <20211210085219.16796-1-pavel.hofman@ivitera.com>
On Fri, Dec 10, 2021 at 09:52:18AM +0100, Pavel Hofman wrote:
> The checks performed by commit aed9d65ac327 ("USB: validate
> wMaxPacketValue entries in endpoint descriptors") require that initial
> value of the maxp variable contains both maximum packet size bits
> (10..0) and multiple-transactions bits (12..11). However, the existing
> code assings only the maximum packet size bits. This patch assigns all
> bits of wMaxPacketSize to the variable.
>
> Fixes: aed9d65ac327 ("USB: validate wMaxPacketValue entries in endpoint descriptors")
> Signed-off-by: Pavel Hofman <pavel.hofman@ivitera.com>
> ---
Acked-by: Alan Stern <stern@rowland.harvard.edu>
This should have a "CC: <stable@vger.kernel.org>" tag attached.
> drivers/usb/core/config.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/core/config.c b/drivers/usb/core/config.c
> index b199eb65f378..74eb356c8767 100644
> --- a/drivers/usb/core/config.c
> +++ b/drivers/usb/core/config.c
> @@ -406,7 +406,7 @@ static int usb_parse_endpoint(struct device *ddev, int cfgno,
> * the USB-2 spec requires such endpoints to have wMaxPacketSize = 0
> * (see the end of section 5.6.3), so don't warn about them.
> */
> - maxp = usb_endpoint_maxp(&endpoint->desc);
> + maxp = le16_to_cpu(endpoint->desc.wMaxPacketSize);
> if (maxp == 0 && !(usb_endpoint_xfer_isoc(d) && asnum == 0)) {
> dev_warn(ddev, "config %d interface %d altsetting %d endpoint 0x%X has invalid wMaxPacketSize 0\n",
> cfgno, inum, asnum, d->bEndpointAddress);
> --
> 2.25.1
>
next prev parent reply other threads:[~2021-12-10 15:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-10 8:52 [PATCH 1/2] usb: core: config: fix validation of wMaxPacketValue entries Pavel Hofman
2021-12-10 8:52 ` [PATCH 2/2] usb: core: config: using bit mask instead of individual bits Pavel Hofman
2021-12-10 15:48 ` Alan Stern
2021-12-10 15:48 ` Alan Stern [this message]
2021-12-10 15:53 ` [PATCH 1/2] usb: core: config: fix validation of wMaxPacketValue entries Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbN2xd7DJuULtOUI@rowland.harvard.edu \
--to=stern@rowland.harvard.edu \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=pavel.hofman@ivitera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox