From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Pavel Hofman <pavel.hofman@ivitera.com>, linux-usb@vger.kernel.org
Subject: Re: [PATCH 1/2] usb: core: config: fix validation of wMaxPacketValue entries
Date: Fri, 10 Dec 2021 16:53:47 +0100 [thread overview]
Message-ID: <YbN4C7XJ8FU4yMGT@kroah.com> (raw)
In-Reply-To: <YbN2xd7DJuULtOUI@rowland.harvard.edu>
On Fri, Dec 10, 2021 at 10:48:21AM -0500, Alan Stern wrote:
> On Fri, Dec 10, 2021 at 09:52:18AM +0100, Pavel Hofman wrote:
> > The checks performed by commit aed9d65ac327 ("USB: validate
> > wMaxPacketValue entries in endpoint descriptors") require that initial
> > value of the maxp variable contains both maximum packet size bits
> > (10..0) and multiple-transactions bits (12..11). However, the existing
> > code assings only the maximum packet size bits. This patch assigns all
> > bits of wMaxPacketSize to the variable.
> >
> > Fixes: aed9d65ac327 ("USB: validate wMaxPacketValue entries in endpoint descriptors")
> > Signed-off-by: Pavel Hofman <pavel.hofman@ivitera.com>
> > ---
>
> Acked-by: Alan Stern <stern@rowland.harvard.edu>
>
> This should have a "CC: <stable@vger.kernel.org>" tag attached.
I can add that, thanks.
greg k-h
prev parent reply other threads:[~2021-12-10 15:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-10 8:52 [PATCH 1/2] usb: core: config: fix validation of wMaxPacketValue entries Pavel Hofman
2021-12-10 8:52 ` [PATCH 2/2] usb: core: config: using bit mask instead of individual bits Pavel Hofman
2021-12-10 15:48 ` Alan Stern
2021-12-10 15:48 ` [PATCH 1/2] usb: core: config: fix validation of wMaxPacketValue entries Alan Stern
2021-12-10 15:53 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbN4C7XJ8FU4yMGT@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=pavel.hofman@ivitera.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox