From: Alan Stern <stern@rowland.harvard.edu>
To: Rob Herring <robh@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: uhci: Use platform_get_irq() to get the interrupt
Date: Thu, 16 Dec 2021 11:10:10 -0500 [thread overview]
Message-ID: <Ybtk4qqN2NYQSZKP@rowland.harvard.edu> (raw)
In-Reply-To: <20211215225203.1991003-1-robh@kernel.org>
On Wed, Dec 15, 2021 at 04:52:03PM -0600, Rob Herring wrote:
> Accessing platform device resources directly has long been deprecated for
> DT as IRQ resources may not be available at device creation time. Drivers
> continuing to use static IRQ resources is blocking removing the static setup
> from the DT core code.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
Acked-by: Alan Stern <stern@rowland.harvard.edu>
> drivers/usb/host/uhci-platform.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/uhci-platform.c b/drivers/usb/host/uhci-platform.c
> index 70dbd95c3f06..b854699e9e4e 100644
> --- a/drivers/usb/host/uhci-platform.c
> +++ b/drivers/usb/host/uhci-platform.c
> @@ -132,7 +132,11 @@ static int uhci_hcd_platform_probe(struct platform_device *pdev)
> goto err_rmr;
> }
>
> - ret = usb_add_hcd(hcd, pdev->resource[1].start, IRQF_SHARED);
> + ret = platform_get_irq(pdev, 0);
> + if (ret < 0)
> + goto err_clk;
> +
> + ret = usb_add_hcd(hcd, ret, IRQF_SHARED);
> if (ret)
> goto err_clk;
>
> --
> 2.32.0
>
prev parent reply other threads:[~2021-12-16 16:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-15 22:52 [PATCH] usb: uhci: Use platform_get_irq() to get the interrupt Rob Herring
2021-12-16 16:10 ` Alan Stern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ybtk4qqN2NYQSZKP@rowland.harvard.edu \
--to=stern@rowland.harvard.edu \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox