From: Alan Stern <stern@rowland.harvard.edu>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: gregkh@linuxfoundation.org, mathias.nyman@linux.intel.com,
Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Andrew Lunn <andrew@lunn.ch>, Rajat Jain <rajatja@google.com>,
Chris Chiu <chris.chiu@canonical.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] usb: core: Avoid doing warm reset on disconnect event
Date: Tue, 21 Dec 2021 09:30:02 -0500 [thread overview]
Message-ID: <YcHk6pam0plSFT3M@rowland.harvard.edu> (raw)
In-Reply-To: <CAAd53p6uXBa2zms1M0aqvRhVWq-kNtw2LvgE5ai94NWMDi5rYQ@mail.gmail.com>
On Tue, Dec 21, 2021 at 11:35:25AM +0800, Kai-Heng Feng wrote:
> (
>
>
> On Fri, Nov 26, 2021 at 11:30 PM Alan Stern <stern@rowland.harvard.edu> wrote:
> > Why is it correct to skip doing a warm reset on a disconnected port here, but not
> > correct to skip doing a warm reset on a disconnected port in all the other places
> > where hub_port_warm_reset_required() gets called?
>
> Can a disconnect event happens to other places other than port_event()?
A disconnect can happen at any time. After all, users can unplug USB
cables whenever they want.
Alan Stern
next prev parent reply other threads:[~2021-12-21 14:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-26 11:56 [PATCH v2] usb: core: Avoid doing warm reset on disconnect event Kai-Heng Feng
2021-11-26 15:30 ` Alan Stern
2021-12-21 3:35 ` Kai-Heng Feng
2021-12-21 14:30 ` Alan Stern [this message]
2021-11-29 10:19 ` Mathias Nyman
2021-11-30 2:36 ` Kai-Heng Feng
2021-12-02 3:10 ` Kai-Heng Feng
2021-12-03 14:17 ` Mathias Nyman
2021-12-06 2:52 ` Kai-Heng Feng
2021-12-21 3:35 ` Kai-Heng Feng
2021-12-22 15:11 ` Mathias Nyman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YcHk6pam0plSFT3M@rowland.harvard.edu \
--to=stern@rowland.harvard.edu \
--cc=Thinh.Nguyen@synopsys.com \
--cc=andrew@lunn.ch \
--cc=chris.chiu@canonical.com \
--cc=gregkh@linuxfoundation.org \
--cc=kai.heng.feng@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
--cc=rajatja@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox