From: Andrew Lunn <andrew@lunn.ch>
To: Matthias-Christian Ott <ott@mirix.org>
Cc: Petko Manolov <petkan@nucleusys.com>,
linux-usb@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] net: usb: pegasus: Do not drop long Ethernet frames
Date: Sun, 26 Dec 2021 17:31:45 +0100 [thread overview]
Message-ID: <YciY8Useao5hfIAF@lunn.ch> (raw)
In-Reply-To: <a87c4ea5-72ef-8dd3-de98-01f799d627ef@mirix.org>
> > I've nothing against this patch, but if you are working on the driver,
> > it would be nice to replace these hex numbers with #defines using BIT,
> > or FIELD. It will make the code more readable.
>
> Replacing the constants with macros is on my list of things that I want
> to do. In this case, I did not do it because I wanted to a have small
> patch that gets easily accepted and allows me to figure out the current
> process to submit patches after years of inactivity.
Agreed, keep fixes simple.
A few other hints. If you consider this a fix which should be back
ported, please add a Fixes: tag, where the issue started. This can be
back as far as the first commit for the driver. Fixes should also be
sent to the net tree, not net-next. See the netdev FAQ about the two
different trees.
Andrew
next prev parent reply other threads:[~2021-12-26 16:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-26 13:29 [PATCH] net: usb: pegasus: Do not drop long Ethernet frames Matthias-Christian Ott
2021-12-26 15:39 ` Andrew Lunn
2021-12-26 16:01 ` Matthias-Christian Ott
2021-12-26 16:31 ` Andrew Lunn [this message]
2021-12-26 22:21 ` Matthias-Christian Ott
2021-12-26 22:28 ` Petko Manolov
2021-12-27 9:56 ` Sergei Shtylyov
2022-01-02 14:22 ` Matthias-Christian Ott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YciY8Useao5hfIAF@lunn.ch \
--to=andrew@lunn.ch \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ott@mirix.org \
--cc=petkan@nucleusys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox